Skip to contentSkip to conversation

v2.6.24-rc1-497-gb1d08ac: kde battery icon gone

regression Thomas Meyer 4 participants 7 messages Nov 2, 2007 – Nov 11, 2007 3 messages not in the archive ACPI

lore
Share & tools
lore

Thomas Meyer

author
#0 lore raw

i just wanted to report this:

in v2.6.24-rc1-497-gb1d08ac the kde battery icon is no longer displayed.

with 2.6.23 shows the battery icon.

current config:

grep -i acpi .config
# Power management options (ACPI, APM)
CONFIG_ACPI=y
CONFIG_ACPI_SLEEP=y
# CONFIG_ACPI_PROCFS is not set
CONFIG_ACPI_PROC_EVENT=y
CONFIG_ACPI_AC=m
CONFIG_ACPI_BATTERY=m
CONFIG_ACPI_BUTTON=m
CONFIG_ACPI_VIDEO=m
CONFIG_ACPI_FAN=m
CONFIG_ACPI_DOCK=m
CONFIG_ACPI_BAY=m
CONFIG_ACPI_PROCESSOR=m
CONFIG_ACPI_HOTPLUG_CPU=y
CONFIG_ACPI_THERMAL=m
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_TOSHIBA is not set
CONFIG_ACPI_BLACKLIST_YEAR=0
CONFIG_ACPI_DEBUG=y
# CONFIG_ACPI_DEBUG_FUNC_TRACE is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_SYSTEM=y
CONFIG_ACPI_CONTAINER=m
CONFIG_ACPI_SBS=m
CONFIG_X86_ACPI_CPUFREQ=m
# CONFIG_X86_ACPI_CPUFREQ_PROC_INTF is not set
CONFIG_HOTPLUG_PCI_ACPI=m
# CONFIG_HOTPLUG_PCI_ACPI_IBM is not set
CONFIG_PNPACPI=y
# CONFIG_THINKPAD_ACPI is not set
CONFIG_ATA_ACPI=y
# CONFIG_PATA_ACPI is not set

#1 lore raw
Quoted 3 lines · Thomas Meyer

i just wanted to report this:

in v2.6.24-rc1-497-gb1d08ac the kde battery icon is no longer displayed.

Appropriate CCs added.

Quoted 40 lines

with 2.6.23 shows the battery icon.

current config:

grep -i acpi .config
# Power management options (ACPI, APM)
CONFIG_ACPI=y
CONFIG_ACPI_SLEEP=y
# CONFIG_ACPI_PROCFS is not set
CONFIG_ACPI_PROC_EVENT=y
CONFIG_ACPI_AC=m
CONFIG_ACPI_BATTERY=m
CONFIG_ACPI_BUTTON=m
CONFIG_ACPI_VIDEO=m
CONFIG_ACPI_FAN=m
CONFIG_ACPI_DOCK=m
CONFIG_ACPI_BAY=m
CONFIG_ACPI_PROCESSOR=m
CONFIG_ACPI_HOTPLUG_CPU=y
CONFIG_ACPI_THERMAL=m
# CONFIG_ACPI_ASUS is not set
# CONFIG_ACPI_TOSHIBA is not set
CONFIG_ACPI_BLACKLIST_YEAR=0
CONFIG_ACPI_DEBUG=y
# CONFIG_ACPI_DEBUG_FUNC_TRACE is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_SYSTEM=y
CONFIG_ACPI_CONTAINER=m
CONFIG_ACPI_SBS=m
CONFIG_X86_ACPI_CPUFREQ=m
# CONFIG_X86_ACPI_CPUFREQ_PROC_INTF is not set
CONFIG_HOTPLUG_PCI_ACPI=m
# CONFIG_HOTPLUG_PCI_ACPI_IBM is not set
CONFIG_PNPACPI=y
# CONFIG_THINKPAD_ACPI is not set
CONFIG_ATA_ACPI=y
# CONFIG_PATA_ACPI is not set

-

#2 lore raw
In reply to Thomas Meyer
Quoted 6 lines · Thomas Meyer

i just wanted to report this:

in v2.6.24-rc1-497-gb1d08ac the kde battery icon is no longer displayed.

with 2.6.23 shows the battery icon.

Quoted 7 lines

current config:

grep -i acpi .config
# Power management options (ACPI, APM)
CONFIG_ACPI=y
CONFIG_ACPI_SLEEP=y
# CONFIG_ACPI_PROCFS is not set

And if you enable it (ACPI_PROCFS)?

#3 lore raw
Quoted 3 lines · Andrey Borzenkov
Quoted 1 line

# CONFIG_ACPI_PROCFS is not set

And if you enable it (ACPI_PROCFS)?

ACPI_PROCFS was newly introduced i think but without a 'default y' Kconfig entry. That was a mistake i think - it broke some power management tools on my laptop too.

Ingo

#4 lore raw
Quoted 9 lines · Ingo Molnar
Quoted 3 lines · Andrey Borzenkov
Quoted 1 line

# CONFIG_ACPI_PROCFS is not set

And if you enable it (ACPI_PROCFS)?

ACPI_PROCFS was newly introduced i think but without a 'default y' Kconfig entry. That was a mistake i think - it broke some power management tools on my laptop too.

It is not that new but battery started to make use of it only now. It provides replacement interface via sysfs power_supply object; this should be supported by modern power tools - at least hal/kpowersave do not have any issues.

-andrey

author
#5 lore raw
In reply to Andrey Borzenkov
Quoted 11 lines · Andrey Borzenkov
Quoted 8 lines · Thomas Meyer

i just wanted to report this:

in v2.6.24-rc1-497-gb1d08ac the kde battery icon is no longer displayed.

with 2.6.23 shows the battery icon.

current config:

Quoted 9 lines
Quoted 6 lines

grep -i acpi .config
# Power management options (ACPI, APM)
CONFIG_ACPI=y
CONFIG_ACPI_SLEEP=y
# CONFIG_ACPI_PROCFS is not set

And if you enable it (ACPI_PROCFS)?

And there it is again...

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw
Quoted 14 lines · Rafael J. Wysocki
Quoted 14 lines

See this commit:

commit fb804714560463534ebcb538a3b0a3c687a830ec

Author: Len Brown <[email protected]>
Date:   Tue Jul 24 01:50:46 2007 -0400

ACPI: Kconfig: CONFIG_ACPI_PROCFS now defaults to N

delete "default y" from CONFIG_ACPI_PROCFS
(effectively making the default 'N')

List exactly what /proc files this option controls, and clarify that it doesn't change non-deprecated files.

Quoted 8 lines
Quoted 3 lines
Signed-off-by Len Brown <[email protected]>

So at least battery change should have added /proc/acpi/battery to this list.

IMHO, the source of the problem is the battery change that has introduced the dependency on ACPI_PROCFS _although_ it's unset by default and that is a regression (ie. confuses users with older user space).

"older user space" meaning just about every Linux box that is out there at the moment. So this is a regression, the user does not care why it happened, and needs fixing.

Quoted 4 lines
Quoted 1 line

May be we need separate ACPI_PROCFS_xxx for every subsystem.

Well, I'm not sure. I think that documenting the dependency should be sufficient.

No. We never remove a bit of relied-on API from the kernel like that. At minimum it must go through a long deprecation cycle before it's turned off by default. Really, is this some sort of weird "how can we piss off and lose as many beta testers as possible in the shortest amount of time" contest? Will people search for a few new lines of documentation (out of the 1 million lines of kernel code that 2.6.24 changes) when 'make oldconfig' breaks their laptop setup - or will they just go over to a more tester-friendly project? Compatibility is our utmost priority (and your regressions list is a very good tool for us to keep compatibility), especially in an incredibly easy case like this where the fix is 1 changed byte with no harm done to anyone.

Ingo