Skip to contentSkip to conversation

Fix typo #ifdef -> #ifndef

PATCH In review Jochen Friedrich 2 participants 2 messages Nov 3, 2007 – Nov 9, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix typo #ifdef -> #ifndef

fpi->cp_command should be overwritten only if CONFIG_PPC_CPM_NEW_BINDING is NOT set. Otherwise it is already set from the device tree.

---

This can be pulled from git://git.bocc.de/dbox2.git for-2.6.24

drivers/net/fs_enet/mac-scc.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/fs_enet/mac-scc.c +0 -0
index 03134f4..48f2f30 100644
@@ -158,7 +158,7 @@ static int setup_data(struct net_device *dev)
{
	struct fs_enet_private *fep = netdev_priv(dev);

-#ifdef CONFIG_PPC_CPM_NEW_BINDING
+#ifndef CONFIG_PPC_CPM_NEW_BINDING

	struct fs_platform_info *fpi = fep->fpi;

	fep->scc.idx = fs_get_scc_index(fpi->fs_no);
Signature · 1 line
1.5.3.4
#1 lore raw
Quoted 2 lines · On Sat, 03 Nov 2007 20:16:36 +0100 Jochen Friedrich <[email protected]> wrote:

Subject: [PATCH] [POWERPC] Fix typo #ifdef -> #ifndef

Please put the "powerpc" outside the []. Because things inside [] get removed when the receiver applies the patch, but the subsystem identification ("powerpc") is useful information which we want to carry into the permanent git record. (Although Paul might add it anyway - some git tree maintainers do).

Quoted 1 line

User-Agent: Mozilla-Thunderbird 2.0.0.6 (X11/20071009)

This seems to be setting a record for MUA vandalism. Leading spaces were removed and various esoteric whitespace transformations were made. The diffs were small so I fixed them by hand.

Please strangle your email client.