Enable loopback disk image files on readonly nfs filesystem

Hi all,

This small patch enables you to loopback disk image files on readonly nfs filesystem on some system.

When we losetup a file on readonly nfs filesystem, it fails with:

# losetup /dev/loop7 /data/vm/xen_el5_i386_para/system.raw
/data/vm/xen_el5_i386_para/system.raw: Permission denied

New version of losetup has add a "-r" option for readonly loop, which Linux kernel has supported for a long time. Some distribution (EL5 update, Fedora 8, etc.) have shipped it. This patch benefit this option while doesn't break the old versions of losetup.

regards,

zhigang

@@ -326,7 +326,10 @@
           fatal 'Failed to find an unused loop device'
         fi
 
-        do_or_die losetup "$loopdev" "$file"
+        status=$(losetup "$loopdev" "$file" || echo "failed")
+        if [ -n "$status" ]; then
+          do_or_die losetup -r "$loopdev" "$file"
+        fi
         xenstore_write "$XENBUS_PATH/node" "$loopdev"
         write_dev "$loopdev"
         release_lock "block"

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel