Skip to contentSkip to conversation

FRV - remove dead config symbol from FRV code

PATCH In review Jiri Olsa 2 participants 5 messages Nov 8, 2007 Kernel janitors

lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 FRV - remove dead config symbol from FRV code

remove dead config symbol from FRV code

---
 include/asm-frv/page.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
include/asm-frv/page.h +0 -4
index 213d92f..bd9bd2d 100644
@@ -76,10 +76,6 @@ extern unsigned long max_pfn;
 
 #endif /* __ASSEMBLY__ */
 
-#ifdef CONFIG_CONTIGUOUS_PAGE_ALLOC
-#define WANT_PAGE_VIRTUAL	1
-#endif
-
 #include <asm-generic/memory_model.h>
 #include <asm-generic/page.h>
 
#1 lore raw
Quoted 1 line · Jiri Olsa

remove dead config symbol from FRV code

Are you sure about that?

warthog>grep -r WANT_PAGE_VIRTUAL mm
mm/highmem.c:#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
mm/page_alloc.c:#ifdef WANT_PAGE_VIRTUAL

David

author
#2 lore raw
In reply to Jiri Olsa
Quoted 4 lines · David Howells
Quoted 1 line · Jiri Olsa

remove dead config symbol from FRV code

Quoted 8 lines

Are you sure about that?

warthog>grep -r WANT_PAGE_VIRTUAL mm
mm/highmem.c:#endif /* defined(CONFIG_HIGHMEM) && !defined(WANT_PAGE_VIRTUAL) */
mm/page_alloc.c:#ifdef WANT_PAGE_VIRTUAL

David

the WANT_PAGE_VIRTUAL is defined only when CONFIG_CONTIGUOUS_PAGE_ALLOC is defined, which wont happend, since it is not defined at all:

-#ifdef CONFIG_CONTIGUOUS_PAGE_ALLOC
-#define WANT_PAGE_VIRTUAL 1
-#endif
-

jirka

#3 lore raw
In reply to Jiri Olsa
Quoted 2 lines · Jiri Olsa

the WANT_PAGE_VIRTUAL is defined only when CONFIG_CONTIGUOUS_PAGE_ALLOC is defined, which wont happend, since it is not defined at all:

Okay. That makes sense.

David