Skip to contentSkip to conversation

priority fix in do_abort(); drivers/scsi/{atari,sun3}_NCR5380.c

PATCH New Roel Kluin 1 participant 1 message Nov 15, 2007 SCSI

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 priority fix in do_abort(); drivers/scsi/{atari,sun3}_NCR5380.c

This patch was not tested.
--
SR_REQ is defined 0x20, but bitanding has no effect because '!' has a higher priority than '&'

Signed-off-by Roel Kluin <[email protected]>

---

drivers/scsi/atari_NCR5380.c +1 -1
index 03dbe60..5696588 100644
@@ -1870,7 +1870,7 @@ static int do_abort(struct Scsi_Host *host)
 	 * the target sees, so we just handshake.
 	 */
 
-	while (!(tmp = NCR5380_read(STATUS_REG)) & SR_REQ)
+	while (!((tmp = NCR5380_read(STATUS_REG)) & SR_REQ))
 		;
 
 	NCR5380_write(TARGET_COMMAND_REG, PHASE_SR_TO_TCR(tmp));
drivers/scsi/sun3_NCR5380.c +1 -1
index 98e3fe1..19852c5 100644
@@ -1864,7 +1864,7 @@ static int do_abort (struct Scsi_Host *host)
      * the target sees, so we just handshake.
      */
     
-    while (!(tmp = NCR5380_read(STATUS_REG)) & SR_REQ);
+    while (!((tmp = NCR5380_read(STATUS_REG)) & SR_REQ));
 
     NCR5380_write(TARGET_COMMAND_REG, PHASE_SR_TO_TCR(tmp));