Skip to contentSkip to conversation

UML : adding X86_32 config to UML's Kconfig

PATCH In review Jiri Olsa 2 participants 2 messages Nov 22, 2007

Subsystems (2)
lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 UML : adding X86_32 config to UML's Kconfig

Hi,

I noticed UM config is not working properly for CPU selection. I bisected following commit as a source:

commit 1032c0ba9da5c5b53173ad2dcf8b2a2da78f8b17

Author: Sam Ravnborg <[email protected]>
Date:   Tue Nov 6 21:35:08 2007 +0100

x86: arch/x86/Kconfig.cpu unification

Move all CPU definitions to Kconfig.cpu Always define X86_MINIMUM_CPU_FAMILY and do the obvious code cleanup in boot/cpucheck.c

Comments from: Adrian Bunk <[email protected]> incorporated.

Cc Adrian Bunk <[email protected]>
Cc Brian Gerst <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>

snip

arch/x86/Kconfig.cpu +2 -1
index 0e2adad..c301622 100644
@@ -3,11 +3,12 @@ if !X86_ELAN
 
 choice
        prompt "Processor family"
-       default M686
+       default M686 if X86_32
+       default GENERIC_CPU if X86_64
 
 

snip

I'm not sure if this is the right way but following patch is working for me.

---
 arch/um/Kconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
arch/um/Kconfig +4 -0
index dd1689b..3dcc17c 100644
@@ -68,6 +68,10 @@ config IRQ_RELEASE_METHOD
 	bool
 	default y
 
+config X86_32
+	bool
+	def_bool !64BIT
+
 menu "UML-specific options"
 
 config STATIC_LINK

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

#1 lore raw
Quoted 1 line · Jiri Olsa

I'm not sure if this is the right way but following patch is working for me.

Thanks - I sent in the following equivalent patch a few days ago -

	http://marc.info/?l=linux-kernel&m=119549989631288&q=raw

				Jeff
Signature · 10 lines
Work email - jdike at linux dot intel dot com

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel