Skip to contentSkip to conversation

questions regarding function autoconfig(); drivers/serial/8250.c

DISCUSSION Roel Kluin 2 participants 3 messages Nov 23, 2007 – Nov 26, 2007 TTY layer and serial drivers

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

In drivers/serial/8250.c:995 it reads:

if (!up->port.iobase && !up->port.mapbase && !up->port.membase)

	return;

As you can see the test !up->port.mapbase is duplicated, which makes no sense. maybe a different test was intended here?
also since membase is a pointer shouldn't the '&&' be replaced with '||'?

thanks,

Roel

#1 lore raw
Quoted 7 lines · Roel Kluin

In drivers/serial/8250.c:995 it reads:

if (!up->port.iobase && !up->port.mapbase && !up->port.membase)

	return;

As you can see the test !up->port.mapbase is duplicated, which makes no sense. maybe a different test was intended here?

Looking twice exposes that the second mapbase is actually a membase. So it looks right to me.

Best regards
Uwe

Signature · 7 lines
Uwe Kleine-König

http://www.google.com/search?q=30+hours+and+4+days+in+seconds
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author
#2 lore raw
Quoted 6 lines · Uwe Kleine-König
Quoted 5 lines · Roel Kluin

In drivers/serial/8250.c:995 it reads:

if (!up->port.iobase && !up->port.mapbase && !up->port.membase)

	return;
Quoted 7 lines
Quoted 2 lines

As you can see the test !up->port.mapbase is duplicated, which makes no sense. maybe a different test was intended here?

Looking twice exposes that the second mapbase is actually a membase. So it looks right to me.

Best regards
Uwe

Thanks for the regards, clearly I need some glasses to improve mine.

Roel
-
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html