Skip to contentSkip to conversation

Out of tree module using LSM

DISCUSSION Crispin Cowan 2 participants 4 messages Nov 30, 2007 – Dec 1, 2007

lore
Share & tools
lore
#0 lore raw
Quoted 4 lines · Tvrtko A. Ursulin

During one recent LKML discussion
(http://marc.info/?l=linux-kernel&m=119267398722085&w=2) about LSM going
static you called for LSM users to speak up.

Great big clue: If "LSM" is in the subject line, then cc: the LSM list [email protected]

For LSM readers seeing this for the first time, the thread starts here and goes for a while http://lkml.org/lkml/2007/11/28/106

I'm sympathetic to the desire to be able to provide a 3rd party LSM that end users can install on their systems. That is why I advocated for keeping the dynamic LSM interface. Getting the dynamic interface restored faces a lot of challenges, but I hope that some kind of solution can be found, because the alternative is to effectively force vendors like Sophos to do it the "dirty" way by fishing in memory for the syscall table. I would much rather that Linux offers you a way to do what you need to do than force you to do nasty things.

Crispin

Signature · 3 lines
Crispin Cowan, Ph.D.               http://crispincowan.com/~crispin
CEO, Mercenary Linux		   http://mercenarylinux.com/
	       Itanium. Vista. GPLv3. Complexity at work
#1 lore raw
Quoted 4 lines · Crispin Cowan

restored faces a lot of challenges, but I hope that some kind of solution can be found, because the alternative is to effectively force vendors like Sophos to do it the "dirty" way by fishing in memory for the syscall table.

I don't think this is quite correct.

The alternative is to engage with the kernel community to become part of the development process, to ensure that appropriate APIs are implemented, and to get code upstream before shipping it.

In any case, a patch to revert the dynamic aspect of LSM has been posted by Arjan (and acked by myself) for the case of valid out of tree users. The only case of this so far has been Multiadm, although there seems to be no reason for it to stay out of tree.

- James

Signature · 2 lines
James Morris 
<[email protected]>
#2 lore raw
Quoted 6 lines · James Morris
Quoted 5 lines · Crispin Cowan

restored faces a lot of challenges, but I hope that some kind of solution can be found, because the alternative is to effectively force vendors like Sophos to do it the "dirty" way by fishing in memory for the syscall table.

Quoted 6 lines

I don't think this is quite correct.

The alternative is to engage with the kernel community to become part of the development process, to ensure that appropriate APIs are implemented, and to get code upstream before shipping it.

That would be part of the "some kind of solution can be found" so I think we are in agreement here.

Quoted 5 lines

In any case, a patch to revert the dynamic aspect of LSM has been posted by Arjan (and acked by myself) for the case of valid out of tree users. The only case of this so far has been Multiadm, although there seems to be no reason for it to stay out of tree.

Dazuko. It has the same yucky code issues as Talpa, but AFAIK is pure GPL2 and thus is clean on the license issues.

That these modules are valid modules that users want to use, are GPL clean, and are *not* something LKML wants to upstream because of code issues, is precisely why the LSM interface makes sense.

Crispin

Signature · 3 lines
Crispin Cowan, Ph.D.               http://crispincowan.com/~crispin
CEO, Mercenary Linux		   http://mercenarylinux.com/
	       Itanium. Vista. GPLv3. Complexity at work
#3 lore raw
Quoted 9 lines · Crispin Cowan
Quoted 3 lines

The only case of this so far has been Multiadm, although there seems to be no reason for it to stay out of tree.

Dazuko. It has the same yucky code issues as Talpa, but AFAIK is pure GPL2 and thus is clean on the license issues.

That these modules are valid modules that users want to use, are GPL clean, and are *not* something LKML wants to upstream because of code issues, is precisely why the LSM interface makes sense.

I think the idea is to try and fix code quality issues through participation in the upstream process, rather than have upstream maintain stable kernel APIs which are naturally mismatched to the unknown requirements of out of tree users.

- James

Signature · 2 lines
James Morris 
<[email protected]>