Skip to contentSkip to conversation

Propagate x86_compat return code

PATCH In review beth kon 1 participant 2 messages Dec 4, 2007

lore
Share & tools
lore

beth kon

author
#0 lore raw

PATCH 1/1 Propagate x86_compat return code

This patch propagates the return code from x86_compat through arch_setup_meminit.

--

tools/libxc/xc_dom_x86.c Tue Dec 04 09:27:33 2007 -0500 renamed from tools/libxc/xc_dom_x86.c Tue Dec 04 09:56:10 2007 +0000 +3 -1
diff -r 8e3d42fdb8e7 tools/libxc/xc_dom_x86.c
@@ -694,7 +694,9 @@ int arch_setup_meminit(struct xc_dom_ima
    int rc;
    xen_pfn_t pfn;
 
-    x86_compat(dom->guest_xc, dom->guest_domid, dom->guest_type);
+    rc = x86_compat(dom->guest_xc, dom->guest_domid, dom->guest_type);
+    if ( rc )
+        return rc;
    if ( xc_dom_feature_translated(dom) )
    {
        dom->shadow_enabled = 1;
Signature · 4 lines
Elizabeth Kon (Beth)
IBM Linux Technology Center
Open Hypervisor Team
email: [email protected]
author
#1 lore raw

Not sure how you handle it, but this fix is also needed for xen 3.1.2.

Quoted 21 lines · beth kon

This patch propagates the return code from x86_compat through arch_setup_meminit.

Signature · 1 line
diff -r 8e3d42fdb8e7 tools/libxc/xc_dom_x86.c
tools/libxc/xc_dom_x86.c Tue Dec 04 09:27:33 2007 -0500 renamed from tools/libxc/xc_dom_x86.c Tue Dec 04 09:56:10 2007 +0000 +3 -1
@@ -694,7 +694,9 @@ int arch_setup_meminit(struct xc_dom_ima
    int rc;
    xen_pfn_t pfn;
 
-    x86_compat(dom->guest_xc, dom->guest_domid, dom->guest_type);
+    rc = x86_compat(dom->guest_xc, dom->guest_domid, dom->guest_type);
+    if ( rc )
+        return rc;
    if ( xc_dom_feature_translated(dom) )
    {
        dom->shadow_enabled = 1;
Signature · 4 lines
Elizabeth Kon (Beth)
IBM Linux Technology Center
Open Hypervisor Team
email: [email protected]