remove pointless code

PATCH New Jan Beulich 1 participant 1 message Dec 6, 2007 Xen hypervisor interface

lore

Share & tools

lore

Jan Beulich

author

2007-12-06 15:28 UTC #0 lore raw

PATCH 1/1 remove pointless code

I'm not sure whether this code was ever good for anything, but it seems definitely pointless.

As usual, written against 2.6.24-rc3 and made apply against 2.6.18 without further testing.

Signed-off-by Jan Beulich <[email protected]>

drivers/xen/netback/xenbus.c +0 -2

Index: head-2007-11-30/drivers/xen/netback/xenbus.c
===================================================================
@@ -172,8 +172,6 @@ static int netback_uevent(struct xenbus_
 
 	add_uevent_var(envp, num_envp, &i, buffer, buffer_size, &length,
 		       "vif=%s", netif->dev->name);
-
-	envp[i] = NULL;
 
 	return 0;
 }

drivers/xen/xenbus/xenbus_probe_backend.c +0 -7

Index: head-2007-11-30/drivers/xen/xenbus/xenbus_probe_backend.c
===================================================================
@@ -155,13 +155,6 @@ static int xenbus_uevent_backend(struct 
 
 	add_uevent_var(envp, num_envp, &i, buffer, buffer_size, &length,
 		       "XENBUS_BASE_PATH=%s", xenbus_backend.root);
-
-	/* terminate, set to next free slot, shrink available space */
-	envp[i] = NULL;
-	envp = &envp[i];
-	num_envp -= i;
-	buffer = &buffer[length];
-	buffer_size -= length;
 
 	if (dev->driver) {
 		drv = to_xenbus_driver(dev->driver);