Skip to contentSkip to conversation

kill mk_pte_huge

PATCH In review Jeremy Fitzhardinge 1 participant 1 message Dec 10, 2007

Subsystems (2)
x86 x86 MM
lore
Share & tools
lore

Jeremy Fitzhardinge

author
#0 lore raw

PATCH 1/4 kill mk_pte_huge

It only has a single use, which can be trivially replaced.

Signed-off-by Jeremy Fitzhardinge <[email protected]>
---
 arch/x86/mm/init_64.c        |    3 +--
 include/asm-x86/pgtable_64.h |    1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

===================================================================

arch/x86/mm/init_64.c +1 -2
@@ -770,8 +770,7 @@ int __meminit vmemmap_populate(struct pa
 			if (!p)
 				return -ENOMEM;
 
-			entry = pfn_pte(__pa(p) >> PAGE_SHIFT, PAGE_KERNEL);
-			mk_pte_huge(entry);
+			entry = pfn_pte(__pa(p) >> PAGE_SHIFT, PAGE_KERNEL_LARGE);
 			set_pmd(pmd, __pmd(pte_val(entry)));
 
 			printk(KERN_DEBUG " [%lx-%lx] PMD ->%p on node %d\n",

===================================================================

include/asm-x86/pgtable_64.h +0 -1
@@ -352,7 +352,6 @@ static inline int pmd_large(pmd_t pte) {
 
 /* page, protection -> pte */
 #define mk_pte(page, pgprot)	pfn_pte(page_to_pfn(page), (pgprot))
-#define mk_pte_huge(entry) (pte_val(entry) |= _PAGE_PRESENT | _PAGE_PSE)
  
 /* Change flags of a PTE */
 static inline pte_t pte_modify(pte_t pte, pgprot_t newprot)