RCU : move three variables to __read_mostly to save space
PATCH 1/1 RCU : move three variables to __read_mostly to save space
I noticed this vmlinux layout on i686 (where CONFIG_X86_L1_CACHE_SHIFT = 7) :
c06cdab4 d pid_caches_lhc06cdb00 d qlowmarkc06cdb04 d qhimarkc06cdb08 d blimitc06cdb80 d rcu_ctrlblkc06cdc80 d rcu_bh_ctrlblk
This means that qlowmark, qhimark and blimit use a whole 128 bytes cache line. Linker is not smart enough for us.
Moving these three variables to read_mostly section saves 116 (128-12) bytes.
# size vmlinux vmlinux.before_patch text data bss dec hex filename 6343966 490818 630784 7465568 71ea60 vmlinux 6343966 490930 630784 7465680 71ead0 vmlinux.before_patch
Signed-off-by Eric Dumazet <[email protected]>
kernel/rcupdate.c +3 -3
@@ -75,9 +75,9 @@ DEFINE_PER_CPU(struct rcu_data, rcu_bh_data) = { 0L };/* Fake initialization required by compiler */ static DEFINE_PER_CPU(struct tasklet_struct, rcu_tasklet) = {NULL}; -static int blimit =10 ; -static int qhimark =10000 ; -static int qlowmark =100 ; +static int blimit__read_mostly =10 ; +static int qhimark__read_mostly =10000 ; +static int qlowmark__read_mostly =100 ;static atomic_t rcu_barrier_cpu_count;static DEFINE_MUTEX (rcu_barrier_mutex);