parport : "dev->timeslice" is an unsigned long, not an int

PATCH New Eric Dumazet 1 participant 1 message Dec 11, 2007 Parallel port

Share & tools

Eric Dumazet

author

2007-12-11 19:49 UTC #0 lore raw

PATCH 1/1 parport : "dev->timeslice" is an unsigned long, not an int

While auditing proc_doulongvec_ms_jiffies_minmax() usage in kernel, I found a bug in drivers/parport/procfs.c, incorrectly using sizeof(int) instead of sizeof(unsigned long)

Only 64bit arches are affected by this old bug.

Signed-off-by Eric Dumazet <[email protected]>

drivers/parport/procfs.c +1 -1

index ed82e41..d950fc3 100644
@@ -384,7 +384,7 @@ parport_device_sysctl_template = {
 		{
 			.procname 	= "timeslice",
 			.data		= NULL,
-			.maxlen		= sizeof(int),
+			.maxlen		= sizeof(unsigned long),
 			.mode		= 0644,
 			.proc_handler	= &proc_doulongvec_ms_jiffies_minmax,
 			.extra1		= (void*) &parport_min_timeslice_value,