Skip to contentSkip to conversation

remove unused variable from drivers/ata/ahci.c

x86_64 Michael Kühn 2 participants 2 messages Dec 14, 2007 – Dec 15, 2007 libata

lore
Share & tools
lore
#0 lore raw

Hi,

my first kernel patch, yay. :-)

On the file drivers/ata/ahci.c in line 1433 is declared a variable that is never used in the function. I removed it.

Patch is in attachments (based on 2.6.23.10).

drivers/ata/ahci.c +0 -1
@@ -1430,7 +1430,6 @@
 {
 	void __iomem *port_mmio = ap->ioaddr.cmd_addr;
 	struct ata_eh_info *ehi = &ap->eh_info;
-	struct ahci_port_priv *pp = ap->private_data;
 	u32 status, qc_active;
 	int rc;
 
#1 lore raw
Quoted 8 lines · Michael Kühn

Hi,

my first kernel patch, yay. :-)

On the file drivers/ata/ahci.c in line 1433 is declared a variable that is never used in the function. I removed it.

Patch is in attachments (based on 2.6.23.10).

...

You'll need to do:

(1) repost it, but this time to [email protected],
(2) place the patch INLINE, where it's easier to comment/correct as needed,
(3) include a Signed-off-by line,
(4) read / follow much of the Documentation/SubmittingPatches file.

*Then* you can try for fame and glory!

:)