Skip to contentSkip to conversation

drivers/ata/ahci.c, kernel 2.6.23.10

PATCH In review Michael Kühn 2 participants 4 messages Dec 15, 2007 libata

lore
Share & tools
lore

Michael Kühn

author
#0 lore raw

PATCH 1/1 drivers/ata/ahci.c, kernel 2.6.23.10

This patch remove a unused variable in the ahci_port_intr function and therewith a compiler warning.

Signed-off-by Michael Kühn <[email protected]>

--- linux-2.6.23.10/drivers/ata/ahci.c 2007-12-14 19:01:59.000000000 +0100
+++ linux-2.6.23.10.new/drivers/ata/ahci.c 2007-12-15
01:03:41.000000000 +0100
@@ -1430,7 +1430,6 @@

 {
        void __iomem *port_mmio = ap->ioaddr.cmd_addr;
        struct ata_eh_info *ehi = &ap->eh_info;
-       struct ahci_port_priv *pp = ap->private_data;
        u32 status, qc_active;
        int rc;
#1 lore raw
Quoted 10 lines · Michael Kühn

This patch remove a unused variable in the ahci_port_intr function and therewith a compiler warning.

Signed-off-by Michael Kühn <[email protected]>
drivers/ata/ahci.c 2007-12-15 renamed from drivers/ata/ahci.c 2007-12-14 19:01:59.000000000 +0100 +0 -0

01:03:41.000000000 +0100

drivers/ata/ahci.c 2007-12-15 line 1434

Quoted 6 lines
drivers/ata/ahci.c 2007-12-15 renamed from drivers/ata/ahci.c 2007-12-14 19:01:59.000000000 +0100 +0 -1
@@ -1430,7 +1430,6 @@
 {
        void __iomem *port_mmio = ap->ioaddr.cmd_addr;
        struct ata_eh_info *ehi = &ap->eh_info;
-       struct ahci_port_priv *pp = ap->private_data;
        u32 status, qc_active;
        int rc;

..

Mmmm.. seems to not be applicable to current 2.6.24-rc*, as the "pp" variable *is* used in that function there.

For older kernels, only serious bugs warrant an update.

Cheers

author
#2 lore raw

Hmm...
but why we shouldn't integrate this fix in 2.6.23* branch?
I thought 2.6.23 and 2.6.24 are indepented from each other and get their own fixes. So it's just a nice have-to-be in the next Bugfix release.

Yours sincerly
Michael Kühn

Quoted 26 lines · Mark Lord
Quoted 11 lines · Michael Kühn

This patch remove a unused variable in the ahci_port_intr function and therewith a compiler warning.

Signed-off-by Michael Kühn <[email protected]>

--- linux-2.6.23.10/drivers/ata/ahci.c 2007-12-14 19:01:59.000000000 +0100
+++ linux-2.6.23.10.new/drivers/ata/ahci.c 2007-12-15
01:03:41.000000000 +0100

Review line 1434

Quoted 6 lines
(quoted diff) +0 -1
@@ -1430,7 +1430,6 @@
 {
        void __iomem *port_mmio = ap->ioaddr.cmd_addr;
        struct ata_eh_info *ehi = &ap->eh_info;
-       struct ahci_port_priv *pp = ap->private_data;
        u32 status, qc_active;
        int rc;

..

Mmmm.. seems to not be applicable to current 2.6.24-rc*, as the "pp" variable *is* used in that function there.

For older kernels, only serious bugs warrant an update.

Cheers

#3 lore raw
Quoted 3 lines · Michael Kühn

Hmm...
but why we shouldn't integrate this fix in 2.6.23* branch?
I thought 2.6.23 and 2.6.24 are indepented from each other and get their own fixes. So it's just a nice have-to-be in the next Bugfix release.

..

You can forward it to GregK, who looks after the backported fixes for those releases, and see if he's interested in it.

Cheers

Quoted 30 lines

Yours sincerly
Michael Kühn

Quoted 26 lines · Mark Lord
Quoted 11 lines · Michael Kühn

This patch remove a unused variable in the ahci_port_intr function and therewith a compiler warning.

Signed-off-by Michael Kühn <[email protected]>

--- linux-2.6.23.10/drivers/ata/ahci.c 2007-12-14 19:01:59.000000000 +0100
+++ linux-2.6.23.10.new/drivers/ata/ahci.c 2007-12-15
01:03:41.000000000 +0100

Review line 1434

Quoted 6 lines
(quoted diff) +0 -1
@@ -1430,7 +1430,6 @@
 {
        void __iomem *port_mmio = ap->ioaddr.cmd_addr;
        struct ata_eh_info *ehi = &ap->eh_info;
-       struct ahci_port_priv *pp = ap->private_data;
        u32 status, qc_active;
        int rc;

..

Mmmm.. seems to not be applicable to current 2.6.24-rc*, as the "pp" variable *is* used in that function there.

For older kernels, only serious bugs warrant an update.

Cheers