: attempt 2: CIFSGetDFSRefer is rewritten to return more information about DFS refferal.
Quoted 1 line · Steve French
Was this current?
Relatively yes.
I've made cleanup patch to CIFSGetDFSRefer on top of what you've recently commited. It should speedup getting DFS to the working state. As minimum, we will get rid of OOPs-es.
Please review attached patch.
Quoted 7 lines
FYI - I removed the section in
link.crather than returning ENOSYSQuoted 3 lines · Q (Igor Mammedov)
1. Now CIFSGetDFSRefer returns array of struct
dfs_info3_paramthat has necessary parameters for handling connect to refferal storage node.
2. Some formating changes to CIFSGetDFSRefer for the sake of checkpatch.
<cut>
Signature · 5 lines
Best regards, ------------------------- Igor Mammedov, niallain "at" gmail.com
Quoted 1 line
From
8914b72c7c9a0e9c1f82a994437e4fa91e2981fcMon Sep 17 00:00:00 2001
From: Igor Mammedov <[email protected]>
Date: Fri, 16 May 2008 13:06:30 +0400
Subject: [PATCH] CIFSGetDFSRefer cleanup
+ dfs_referral_level_3 fixed to conform REFERRAL_V3 the MS-DFSC spec.
--- fs/cifs/cifspdu.h | 16 ++--- fs/cifs/cifssmb.c | 205 ++++++++++++++++++++++++++++++++++------------------- 2 files changed, 139 insertions(+), 82 deletions(-)
fs/cifs/cifspdu.h +7 -9
@@ -1906,17 +1906,15 @@ typedef struct smb_com_transaction2_get_dfs_refer_req {typedef struct dfs_referral_level_3 {__le16 VersionNumber; -__le16 ReferralSize; -__le16 ServerType;/* 0x0001 = CIFS server */ -__le16 ReferralFlags;/* or proximity - not clear which since it is -always set to zero - SNIA spec says 0x01 -means strip off PathConsumed chars before -submitting RequestFileName to remote node */ -__le16 TimeToLive; -__le16 Proximity; +__le16 Size; +__le16 ServerType;/* 0x0001 = root targets; 0x0000 = link targets */ +__le16 ReferralEntryFlags;/* 0x0200 bit set only for domain +or DC referral responce */ +__le32 TimeToLive;__le16 DfsPathOffset;__le16 DfsAlternatePathOffset; -__le16 NetworkAddressOffset; +__le16 NetworkAddressOffset;/* offset of the link target */ +__le16 ServiceSiteGuid; } __attribute__((packed))REFERRAL3 ; typedef struct smb_com_transaction_get_dfs_refer_rsp {
fs/cifs/cifssmb.c +132 -73
236 lines not on this page · raw message
Signature · 1 line
1.5.3.7