PCI: x86 MMCONFIG: introduce PCI_USING_MMCONF]
PATCH 1/5 PCI: x86 MMCONFIG: introduce PCI_USING_MMCONF]
To all,
The next few forwarded messages comprise my responses to Greg's questions about the patch I submitted to deal with pci devices that do not respond correctly to x86 mmconf accesses.
Please accept my apologies for not having including the community in my original responses.
-------- Original Message --------
Subject: Re: [PATCH 1/5]PCI: x86 MMCONFIG: introduce PCI_USING_MMCONF
Date: Wed, 19 Dec 2007 18:58:45 -0500
From: Tony Camuso <[email protected]>
Reply-To: [email protected]
To: Greg KH <[email protected]>
References: <20071219221746.20362.39243.sendpatchset@dhcp83-188.boston.redhat.com> <20071219221751.20362.23451.sendpatchset@dhcp83-188.boston.redhat.com> <[email protected]>
Quoted 10 lines · Greg KH
Quoted 2 lines · On Wed, Dec 19, 2007 at 05:17:51PM -0500, [email protected] wrote:
+extern struct
pci_opspci_legacy_ops; /*direct.c*/This isn't needed in this patch at all, and might make the compiler confused if you were to build with only this patch present :(
thanks,
greg k-h
Yes, of course. I missed that. Thank you.
Should I resubmit that one patch? Or would you prefer I resubmit the whole patch set?
Quoted 6 lines · Tony Camuso
Quoted 4 lines · Greg KH
Quoted 2 lines · On Wed, Dec 19, 2007 at 05:17:51PM -0500, [email protected] wrote:
+extern struct
pci_opspci_legacy_ops; /*direct.c*/
Quoted 9 lines
Quoted 6 lines
This isn't needed in this patch at all, and might make the compiler confused if you were to build with only this patch present :(
thanks,
greg k-h
Yes, of course. I missed that. Thank you.
I take that back.
This struct must be declared extern because it is referenced in arch/x86/pci/common.c by pcibios_fix_bus_scan_quirk()
Quoted 9 lines · Tony Camuso
Quoted 7 lines · Tony Camuso
Quoted 6 lines · Greg KH
Quoted 1 line · On Wed, Dec 19, 2007 at 05:17:51PM -0500, [email protected] wrote:
+extern struct
pci_opspci_legacy_ops; /*direct.c*/This isn't needed in this patch at all, and might make the compiler confused if you were to build with only this patch present :(
Quoted 8 lines
Quoted 4 lines
Quoted 3 lines
thanks,
greg k-h
Yes, of course. I missed that. Thank you.
I take that back.
This struct must be declared extern because it is referenced in
arch/x86/pci/common.cbypcibios_fix_bus_scan_quirk()
Sure, but you do not reference it in this patch, right? So it's not needed until you actually use it, so just include it in the patch that you are needing it in.
thanks,
greg k-h
Quoted 7 lines · Greg KH
Sure, but you do not reference it in this patch, right? So it's not needed until you actually use it, so just include it in the patch that you are needing it in.
thanks,
greg k-h
Will do.