Skip to contentSkip to conversation

PCI: x86 MMCONFIG]

PATCH In review Tony Camuso 1 participant 1 message Dec 20, 2007

lore
Share & tools
lore
#0 lore raw

cover PCI: x86 MMCONFIG]

-------- Original Message --------
Subject: Re: [PATCH 0/5]PCI: x86 MMCONFIG
Date: Wed, 19 Dec 2007 19:44:13 -0500
From: Tony Camuso <[email protected]>
Reply-To: [email protected]
To: Robert Hancock <[email protected]>
References: <[email protected]> <[email protected]> <[email protected]>

Quoted 4 lines · Robert Hancock

Greg KH wrote:

I think we need more details on why this patch is needed. Also, we already have something like this in arch/x86/pci/mmconfig-shared.c, in the unreachable_devices function. This attempts to detect devices where MMCONFIG cannot access the configuration space (one of these would be at least one device in the AMD K8 built-in northbridge). If this is not sufficient, I would suggest expanding that mechanism instead of adding all this new code.

We thought of doing that. But IIRC, unreachable_devices() only covers the first 16 buses on segment 0. What happens to the bitmap when you want to cover all possible buses on all possible segments?

We felt that we had to come up with a more in-line way of doing this.