Skip to contentSkip to conversation

Add polling transfer for i2c-pxa

PATCH RESEND Jean Delvare 4 participants 6 messages Jan 10, 2008 – Jan 11, 2008 3 messages not in the archive

Subsystems (4)
Arm (32-bit) Arm sub-architectures I2C subsystem host drivers PXA2xx/PXA3xx support
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jean Delvare

author
#1 lore raw

Hi Mike,

Quoted 1 line · Mike Rapoport

The below patch adds polling I2C transfer implementation for PXA I2C.

This patch doesn't apply on top of my current stack, most probably due to a conflict with this patch by Eric Miao:

http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/i2c-pxa-use-cpu_is_pxa27x.patch

Can you please update your patch so that it applies cleanly on top of 2.6.24-rc7 + the patch above?

Thanks,

Signature · 6 lines
Jean Delvare

-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php
#2 lore raw
Quoted 5 lines · Jean Delvare

Hi Mike,

Quoted 1 line · Mike Rapoport

The below patch adds polling I2C transfer implementation for PXA I2C.

Quoted 7 lines

This patch doesn't apply on top of my current stack, most probably due to a conflict with this patch by Eric Miao:

http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/i2c-pxa-use-cpu_is_pxa27x.patch

Can you please update your patch so that it applies cleanly on top of 2.6.24-rc7 + the patch above?

Hope this one will go...

Quoted 1 line

Thanks,

Signature · 10 lines
Sincerely yours,
Mike.


Signed-off-by: Mike Rapoport <[email protected]>

 arch/arm/mach-pxa/pxa27x.c     |    6 ++
 drivers/i2c/busses/i2c-pxa.c   |  133 ++++++++++++++++++++++++++++++++++++----
 include/asm-arm/arch-pxa/i2c.h |    6 ++
 3 files changed, 133 insertions(+), 12 deletions(-)
arch/arm/mach-pxa/pxa27x.c +6 -0
index 8e126e6..57efebd 100644
@@ -24,6 +24,7 @@
 #include <asm/arch/ohci.h>
 #include <asm/arch/pm.h>
 #include <asm/arch/dma.h>
+#include <asm/arch/i2c.h>
 
 #include "generic.h"
 #include "devices.h"

@@ -423,6 +424,11 @@ struct platform_device pxa27x_device_i2c_power = {
 	.num_resources	= ARRAY_SIZE(i2c_power_resources),
 };
 
+void __init pxa_set_i2c_power_info(struct i2c_pxa_platform_data *info)
+{
+	pxa27x_device_i2c_power.dev.platform_data = info;
+}
+
 static struct platform_device *devices[] __initdata = {
 	&pxa_device_mci,
 	&pxa_device_udc,
drivers/i2c/busses/i2c-pxa.c +121 -12

199 lines not on this page · raw message

include/asm-arm/arch-pxa/i2c.h +6 -0
index e404b23..80596b0 100644
@@ -65,7 +65,13 @@ struct i2c_pxa_platform_data {
 	unsigned int		slave_addr;
 	struct i2c_slave_client	*slave;
 	unsigned int		class;
+	int			use_pio;
 };
 
 extern void pxa_set_i2c_info(struct i2c_pxa_platform_data *info);
+
+#ifdef CONFIG_PXA27x
+extern void pxa_set_i2c_power_info(struct i2c_pxa_platform_data *info);
+#endif
+
 #endif

-------------------------------------------------------------------

List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

A message that is not in the archive (sent off-list or not yet received): 47860C86.5050801-UTxiZqZC01RS1MOuV/[email protected]

#4 lore raw
Quoted 9 lines · Mike Rapoport
Quoted 8 lines · Jean Delvare

Hi Mike,

Quoted 1 line · Mike Rapoport

The below patch adds polling I2C transfer implementation for PXA I2C.

This patch doesn't apply on top of my current stack, most probably due to a conflict with this patch by Eric Miao:

Quoted 6 lines
Quoted 4 lines

http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/i2c-pxa-use-cpu_is_pxa27x.patch

Can you please update your patch so that it applies cleanly on top of 2.6.24-rc7 + the patch above?

Hope this one will go...

Yes, this one applied just fine, thank you. I've added it to my tree. However I don't have the hardware to test it, I can't even built the i2c-pxa driver. Can someone else please review and/or test the patch and add his/her Acked-by?

Thanks,

Signature · 1 line
Jean Delvare
#5 lore raw
Quoted 24 lines

-----Original Message-----
From: Jean Delvare [mailto:[email protected]]
Sent: Thursday, January 10, 2008 9:55 PM
To: Mike Rapoport
Cc: [email protected]; ARM Linux; Russell King - ARM Linux; Eric Miao
Subject: Re: [i2c] [PATCH 2/2] [resend] Add polling transfer for i2c-pxa

Quoted 10 lines · Mike Rapoport
Quoted 9 lines · Jean Delvare

Hi Mike,

Quoted 1 line · Mike Rapoport

The below patch adds polling I2C transfer implementation for PXA I2C.

This patch doesn't apply on top of my current stack, most probably due to a conflict with this patch by Eric Miao:

http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/i2c-pxa-use-cpu_is_
pxa27x.patch

Quoted 4 lines
Quoted 3 lines

Can you please update your patch so that it applies cleanly on top of 2.6.24-rc7 + the patch above?

Quoted 7 lines
Quoted 1 line

Hope this one will go...

Yes, this one applied just fine, thank you. I've added it to my tree. However I don't have the hardware to test it, I can't even built the i2c-pxa driver. Can someone else please review and/or test the patch and add his/her Acked-by?

I can test this and get back to you by end of today.

Quoted 3 lines

Thanks,
--
Jean Delvare

Acked-by
#6 lore raw
In reply to Jean Delvare
Quoted 24 lines

-----Original Message-----
From: Jean Delvare [mailto:[email protected]]
Sent: Thursday, January 10, 2008 9:55 PM
To: Mike Rapoport
Cc: [email protected]; ARM Linux; Russell King - ARM Linux; Eric Miao
Subject: Re: [i2c] [PATCH 2/2] [resend] Add polling transfer for i2c-pxa

Quoted 10 lines · Mike Rapoport
Quoted 9 lines · Jean Delvare

Hi Mike,

Quoted 1 line · Mike Rapoport

The below patch adds polling I2C transfer implementation for PXA I2C.

This patch doesn't apply on top of my current stack, most probably due to a conflict with this patch by Eric Miao:

http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/i2c-pxa-use-cpu_is_
pxa27x.patch

Quoted 4 lines
Quoted 3 lines

Can you please update your patch so that it applies cleanly on top of 2.6.24-rc7 + the patch above?

Quoted 7 lines
Quoted 1 line

Hope this one will go...

Yes, this one applied just fine, thank you. I've added it to my tree. However I don't have the hardware to test it, I can't even built the i2c-pxa driver. Can someone else please review and/or test the patch and add his/her Acked-by?

Acked-by eric miao <[email protected]>

I've tested this patch on zylonite/pxa3xx platform with both 'use_pio = 0' and 'use_pio = 1', and is known to work.

Quoted 3 lines

Thanks,
--
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): E913911567467945BBEB9277E27868B06BC773-3TKN+kxLw8+HXkj8w7BxOhL4W9x8LtSr@public.gmane.org

#8 lore raw
Quoted 9 lines · Eric Miao
Quoted 4 lines

Yes, this one applied just fine, thank you. I've added it to my tree. However I don't have the hardware to test it, I can't even built the i2c-pxa driver. Can someone else please review and/or test the patch and add his/her Acked-by?

Acked-by eric miao <[email protected]>

I've tested this patch on zylonite/pxa3xx platform with both 'use_pio = 0' and 'use_pio = 1', and is known to work.

Great, thanks Eric!

Signature · 1 line
Jean Delvare