Skip to contentSkip to conversation

Fix '--nosync' option of lvcreate and remove unnecessary tag collection

PATCH New Jun'ichi Nomura 1 participant 1 message Dec 22, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 Fix '--nosync' option of lvcreate and remove unnecessary tag collection

This patch fixes 2 things.

While converting lvcreate to use the newly added lv_add_mirrors(), I mistakenly moved the MIRROR_NOTSYNCED flag setting *after* lv_create_empty().
As a result, '--nosync' option of lvcreate becomes nop.
This patch moves the flag setting and makes nosync option working again.

In the old code, tag list is created and passed for mirror log creation function because the log was created before the LV.
In the current code, linear LV is created first and the log creation function takes tag list from the LV. So we don't need to create tag list in lvcreate.

Thanks,

Signature · 8 lines
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: revive-nosync-option.patch
Type: text/x-patch
Size: 1701 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071221/e5e7b214/attachment.bin>