powerpc: DBox2 Board Support

This patch adds device tree source, default config and setup code for DBox2 devices.

arch/powerpc/platforms/8xx/dbox2.h new file +4 -0

@@ -0,0 +1,30 @@
+/*
+ * A collection of structures, addresses, and values associated with
+ * the DBox2.
+ *

arch/powerpc/platforms/8xx/dbox2_setup.c new file +10 -0

+	if (dbox2_manuf_id == DBOX2_MID_NOKIA)
+		np = of_find_node_by_path("/localbus@8000000/enx@0");
+	else
+		np = of_find_node_by_path("/localbus@8000000/gtx@0");
+
+	if (np) {
+		of_detach_node(np);
+		of_node_put(np);
+	}
+

Quoted 2 lines

This patch adds device tree source, default config and setup code for DBox2 devices.

get one again when it's hitting mainline.

Is this already a complete port, or do you also need some device drivers or boot wrapper code to go along with it?

arch/powerpc/boot/dts/dbox2.dts line 40

Quoted 4 lines

arch/powerpc/boot/dts/dbox2.dts new file +4 -0

+	memory {
+		device_type = "memory";
+		reg = <0 2000000>;
+	};

I thought there are both models with 32MB and 16MB available. If that's true, shouldn't this be filled out by the boot loader?

Quoted 5 lines

arch/powerpc/configs/dbox2_defconfig new file +5 -0

+#
+# Frame buffer hardware drivers
+#
+# CONFIG_FB_OF is not set
+# CONFIG_FB_VGA16 is not set

arch/powerpc/configs/dbox2_defconfig line 771

Quoted 4 lines

arch/powerpc/configs/dbox2_defconfig new file +4 -0

+# CONFIG_FB_S1D13XXX is not set
+# CONFIG_FB_IBM_GXT4500 is not set
+# CONFIG_FB_VIRTUAL is not set
+# CONFIG_BACKLIGHT_LCD_SUPPORT is not set

No hardware framebuffer driver? Can't you use the FB_OF driver by default? I'd guess that a set-top box without output is rather pointless ;-)

arch/powerpc/configs/dbox2_defconfig line 862

Quoted 8 lines

arch/powerpc/configs/dbox2_defconfig new file +8 -0

+# DOS/FAT/NT Filesystems
+#
+CONFIG_FAT_FS=y
+CONFIG_MSDOS_FS=y
+CONFIG_VFAT_FS=y
+CONFIG_FAT_DEFAULT_CODEPAGE=437
+CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
+# CONFIG_NTFS_FS is not set

What media can you connect that use the FAT file system?

I'd guess that if you can get rid of these, you can also disable the entire block layer, which should free up some kernel memory.

Quoted 9 lines

arch/powerpc/platforms/8xx/dbox2.h new file +9 -0

+
+/* Vendor information in BR Bootloader
+ */
+
+#define DBOX2_VENDOR_OFFSET	(0x1ffe0)
+
+enum dbox2_mid {
+	DBOX2_MID_NOKIA       = 1,
+	DBOX2_MID_PHILIPS     = 2,

arch/powerpc/platforms/8xx/dbox2.h line 27

Quoted 4 lines

arch/powerpc/platforms/8xx/dbox2.h new file +4 -0

+	DBOX2_MID_SAGEM       = 3,
+};
+
+enum dbox2_mid dbox2_get_mid(void);

Can you move this functionality from the kernel to the boot wrapper? It looks like this is something that really belongs into the device tree.

Quoted 15 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +15 -0

+	if (dbox2_manuf_id == DBOX2_MID_NOKIA)
+		np = of_find_node_by_path("/localbus@8000000/enx@0");
+	else
+		np = of_find_node_by_path("/localbus@8000000/gtx@0");
+
+	if (np) {
+		of_detach_node(np);
+		of_node_put(np);
+	}
+
+	if (dbox2_manuf_id == DBOX2_MID_PHILIPS)
+		np = of_find_node_by_path("/localbus@8000000/cam@4000000");
+	else
+		np = of_find_node_by_path("/localbus@8000000/cam@4040000");
+

arch/powerpc/platforms/8xx/dbox2_setup.c line 189

Quoted 5 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +5 -0

+	if (np) {
+		of_detach_node(np);
+		of_node_put(np);
+	}
+}

What is this code for? Why do you want to detach nodes from the device tree that have been put in there by the boot loader?

Quoted 5 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +5 -0

+static void __init dbox2_setup_arch(void)
+{
+	struct device_node *np;
+	static u8 __iomem *config;
+

arch/powerpc/platforms/8xx/dbox2_setup.c line 146

Quoted 5 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +5 -0

+	cpm_reset();
+	init_ioports();
+
+	/* Enable external IRQs for AVIA chips */
+	clrbits32(&mpc8xx_immr->im_siu_conf.sc_siumcr, 0x00000c00);

This smells like a hack. What are AVIA chips, and shouldn't their driver enable the IRQs?

arch/powerpc/platforms/8xx/dbox2_setup.c line 203

Quoted 6 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +6 -0

+static struct of_device_id __initdata of_bus_ids[] = {
+	{ .name = "soc", },
+	{ .name = "cpm", },
+	{ .name = "localbus", },
+	{},
+};

Shouldn't this check for 'compatible' properties instead of 'name'?

arch/powerpc/platforms/8xx/dbox2_setup.c line 213

Quoted 9 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +9 -0

+static int __init declare_of_platform_devices(void)
+{
+	/* Publish the QE devices */
+	if (machine_is(dbox2))
+		of_platform_bus_probe(NULL, of_bus_ids, NULL);
+
+	return 0;
+}
+device_initcall(declare_of_platform_devices);

This is a candidate for the new platform_initcall stuff.

I also once did a patch that let you have a default 'of_bus_ids' member in the ppc_md. I never got around to submitting that, but if there is interest, I can dig it out again.

Quoted 6 lines

include/asm-powerpc/mpc8xx.h +0 -0

@@ -23,6 +23,10 @@
 #include <platforms/8xx/mpc885ads.h>
 #endif
 

include/asm-powerpc/mpc8xx.h line 29

Quoted 4 lines

include/asm-powerpc/mpc8xx.h +4 -0

+#if defined(CONFIG_DBOX2)
+#include <platforms/8xx/dbox2.h>
+#endif
+

Don't hide #includes or platform specific #defines in #ifdef.

Quoted 7 lines

arch/powerpc/boot/dts/dbox2.dts line 40

Quoted 4 lines

arch/powerpc/boot/dts/dbox2.dts new file +4 -0

+	memory {
+		device_type = "memory";
+		reg = <0 2000000>;
+	};

I thought there are both models with 32MB and 16MB available. If that's true, shouldn't this be filled out by the boot loader?

IIRC, the cuImage wrapper overwrites this with the boot loader parameters.

OTOH, the memory is part of the localbus (CS1). Should it be a child of localbus in this case?

I didn't check FB_OF. On Dbox2, the avia driver creates a framebuffer device.

There are two mods available using the block layer, although currently i don't support any of them:

1. using the GPIO lines of the modem port, it's possible to connect a SD card. It might be possible to use it using the GPIO SPI driver (but it would need some glue code to create a platform device).

2. using the memory expansion port and CS2, there is an IDE interface available with a CPLD acting as localbus/IDE bridge. There is a device driver for ARCH=ppc.

Unfortunately, i don't own any of these modifications.

Quoted 5 lines

Quoted 5 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +5 -0

+static void __init dbox2_setup_arch(void)
+{
+	struct device_node *np;
+	static u8 __iomem *config;
+

Quoted 8 lines

arch/powerpc/platforms/8xx/dbox2_setup.c line 146

Quoted 5 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +5 -0

+	cpm_reset();
+	init_ioports();
+
+	/* Enable external IRQs for AVIA chips */
+	clrbits32(&mpc8xx_immr->im_siu_conf.sc_siumcr, 0x00000c00);

This smells like a hack. What are AVIA chips, and shouldn't their driver enable the IRQs?

No. This just configures the Pin as IRQ input. Maybe, the new GPIO functions could be used for this, instead. Then it could be done in the driver (the driver should't directly mess with SIU internals).

Quoted 8 lines

arch/powerpc/platforms/8xx/dbox2_setup.c line 203

Quoted 6 lines

arch/powerpc/platforms/8xx/dbox2_setup.c new file +6 -0

+static struct of_device_id __initdata of_bus_ids[] = {
+	{ .name = "soc", },
+	{ .name = "cpm", },
+	{ .name = "localbus", },
+	{},
+};

Shouldn't this check for 'compatible' properties instead of 'name'?

I copied this from mpc885ads_setup.c.

Quoted 3 lines

I also once did a patch that let you have a default 'of_bus_ids' member in the ppc_md. I never got around to submitting that, but if there is interest, I can dig it out again.

That would be nice :)