Add driver for National Semiconductor LM73 temperature sensor

Quoted 14 lines · Stefan Roese

Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD

Quoted 5 lines

drivers/hwmon/Makefile +0 -0

index cebb2ba..32e3f44 100644
@@ -34,6 +34,7 @@ COBJS-y += adm1021.o

Quoted 8 lines

drivers/hwmon/Makefile COBJS-y += adm1021.o · line 39

Quoted 6 lines

drivers/hwmon/Makefile +1 -0

 COBJS-y += ds1621.o
 COBJS-y += ds1722.o
 COBJS-y += ds1775.o
+COBJS-y += lm73.o
 COBJS-y += lm75.o
 COBJS-y += lm81.o

I will send soon (today or tomorow) the Makefile with conditional compilation please rebase your patch about drivers on it.

Quoted 4 lines

I would like to get those patches accepted and merged in this merge window. We should not delay this by waiting on your conditional compilation rework (which is good of course). So I suggest to get such patches merged right now and fix possible problems with future additions later.

I understand you view but il will great if the new driver could be use conditional Makefile.o

Could you do this modification pls

COBJS-$(CONFIG_DTT_LM73) += lm73.o

instead of

Quoted 1 line

+COBJS-y += lm73.o

and remove if ifdef CONFIG_DTT_LM73 from the lm73.c

Thanks by advance,
J.

Quoted 13 lines

I understand you view but il will great if the new driver could be use conditional Makefile.o

Could you do this modification pls

COBJS-$(CONFIG_DTT_LM73) += lm73.o

instead of

Quoted 1 line

+COBJS-y += lm73.o

and remove if ifdef CONFIG_DTT_LM73 from the lm73.c

Quoted 2 lines

Thanks by advance,
J.

I have tested a patch to make this change and to remove the references to "CFG_EEPROM_PAGE_WRITE_ENABLE". If there is no objection, I would prefer to submit this patch after Stefan finishes adding the original patch, rather than amend the original patch.

Quoted 10 lines · Larry Johnson

Quoted 10 lines

I understand you view but il will great if the new driver could be use conditional Makefile.o

Could you do this modification pls

COBJS-$(CONFIG_DTT_LM73) += lm73.o

instead of

Quoted 1 line

+COBJS-y += lm73.o

Quoted 8 lines

Quoted 4 lines

and remove if ifdef CONFIG_DTT_LM73 from the lm73.c

Thanks by advance,
J.

I have tested a patch to make this change and to remove the references to "CFG_EEPROM_PAGE_WRITE_ENABLE". If there is no objection, I would prefer to submit this patch after Stefan finishes adding the original patch, rather than amend the original patch.

Yes, I would like to do it this way too.

I'm waiting for some final patches from Matthias and will send the pull request to Wolfgang after those are merged today or latest tomorrow.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

Well, the changes I tried appear to work for "sequoia", but they break the build for "sequoia_nand". When NAND Sequoia links, it doesn't find "denali_wait_for_dlllock()", so I guess it's not linking in "cpu/ppc4xx/libppc4xx.a"?

In any case, this is what the patch looks like (PPC4xx repository, "for-1.3.2" branch). Matthias, you may want to see if a similar patch would make sense for your code.