Subject: [PATCH] Remove superfluous preprocessor conditionals from LM73 driver

U-Boot-Users Larry Johnson 1 participant 1 message Dec 29, 2007

Subsystems (2)

Hardware monitoring LM73 hardware monitor driver

lore

Share & tools

lore

Larry Johnson

author

2007-12-29 19:10 UTC #0 lore raw

(1) Remove unused symbol "CFG_EEPROM_PAGE_WRITE_ENABLE".

(2) Use conditional Makefile.o.

Signed-off-by Larry Johnson <[email protected]>

---
(Patch applies to PPC4xx "master" branch.)

 drivers/hwmon/Makefile  |    2 +-
 drivers/hwmon/lm73.c    |    9 ---------
 include/configs/korat.h |    1 -
 3 files changed, 1 insertions(+), 11 deletions(-)

drivers/hwmon/Makefile +1 -1

index 32e3f44..065433a 100644
@@ -34,7 +34,7 @@ COBJS-y += adm1021.o
 COBJS-y += ds1621.o
 COBJS-y += ds1722.o
 COBJS-y += ds1775.o
-COBJS-y += lm73.o
+COBJS-$(CONFIG_DTT_LM73) += lm73.o
 COBJS-y += lm75.o
 COBJS-y += lm81.o

drivers/hwmon/lm73.c +0 -9

index f9ae012..db8ef66 100644
@@ -31,13 +31,6 @@
  */
 
 #include <common.h>
-
-#ifdef CONFIG_DTT_LM73
-#if !defined(CFG_EEPROM_PAGE_WRITE_ENABLE) || \
-	(CFG_EEPROM_PAGE_WRITE_BITS < 1)
-# error "CFG_EEPROM_PAGE_WRITE_ENABLE must be defined and CFG_EEPROM_PAGE_WRITE_BITS must be greater than  1 to use CONFIG_DTT_LM73"
-#endif
-
 #include <i2c.h>
 #include <dtt.h>

@@ -177,5 +170,3 @@ int dtt_get_temp(int sensor)
 {
 	return (dtt_read(sensor, DTT_READ_TEMP) + 0x0040) >> 7;
 } /* dtt_get_temp() */
-
-#endif /* CONFIG_DTT_LM73 */

include/configs/korat.h +0 -1

index 312b8c5..a0ea0f3 100644
@@ -156,7 +156,6 @@
 #define CFG_I2C_MULTI_EEPROMS
 #define CFG_I2C_EEPROM_ADDR	(0xa8>>1)
 #define CFG_I2C_EEPROM_ADDR_LEN 1
-#define CFG_EEPROM_PAGE_WRITE_ENABLE
 #define CFG_EEPROM_PAGE_WRITE_BITS 3
 #define CFG_EEPROM_PAGE_WRITE_DELAY_MS 10

Signature · 1 line

1.5.2.5