sata_qstor: use hardreset instead of softreset
PATCH 1/1 sata_qstor: use hardreset instead of softreset
During conversion to new EH, sata_qstor was accidentaly changed to use softreset, which is buggy on this chip, instead of hardreset. This patch updates sata_qstor such that it uses hardreset again.
This fixes bugzilla bug 9631.
--- drivers/ata/sata_qstor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_qstor.c +1 -1
@@ -270,7 +270,7 @@ static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val)static void qs_error_handler (struct ata_port *ap) {qs_enter_reg_mode (ap); -ata_do_eh (ap, qs_prereset, ata_std_softreset,NULL , +ata_do_eh (ap, qs_prereset,NULL , sata_std_hardreset, ata_std_postreset); }
Quoted 17 lines · Tejun Heo
During conversion to new EH,
sata_qstorwas accidentaly changed to use softreset, which is buggy on this chip, instead of hardreset. This patch updatessata_qstorsuch that it uses hardreset again.This fixes bugzilla bug 9631.
Signed-off-by Tejun Heo <[email protected]>Cc Mark Lord <[email protected]>--- drivers/ata/sata_qstor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/ata/sata_qstor.c +0
-0
drivers/ata/sata_qstor.c static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val) · line 276
Quoted 8 lines
drivers/ata/sata_qstor.c +1
-1@@ -270,7 +270,7 @@ static int qs_scr_read(struct ata_port *ap, unsigned int sc_reg, u32 *val)static void qs_error_handler (struct ata_port *ap) {qs_enter_reg_mode (ap); -ata_do_eh (ap, qs_prereset, ata_std_softreset,NULL , +ata_do_eh (ap, qs_prereset,NULL , sata_std_hardreset, ata_std_postreset); }
Ack. This fixes a regression and should go out in 2.6.24.
And now we know that I'm not the only Linux user on the planet with a QStor card -- there's at least one other out there!
Cheers
Jeff Garzik
AppliedQuoted 11 lines · Tejun Heo
During conversion to new EH,
sata_qstorwas accidentaly changed to use softreset, which is buggy on this chip, instead of hardreset. This patch updatessata_qstorsuch that it uses hardreset again.This fixes bugzilla bug 9631.
Signed-off-by Tejun Heo <[email protected]>Cc Mark Lord <[email protected]>--- drivers/ata/sata_qstor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
applied