CONNECTOR: cleanup struct cn_callback_entry

PATCH In review Li Zefan 1 participant 1 message Jan 4, 2008 Network drivers

Share & tools

Li Zefan

author

2008-01-04 05:58 UTC #0 lore raw

PATCH 4/5 CONNECTOR: cleanup struct cn_callback_entry

- 'cb' is a fake struct member. In a previous patch struct cn_callback was renamed to cn_callback_id, so 'cb' should have been deleted at that time.

- 'nls' isn't used and is redundant, we can retrieve this data through cn_callback_entry.pdev->nls.

- 'seq' and 'group' should be u32, as they are declared to be u32 in other places.

Signed-off-by Li Zefan <[email protected]>

---
 drivers/connector/cn_queue.c |    1 -
 include/linux/connector.h    |    4 +---
 2 files changed, 1 insertions(+), 4 deletions(-)

drivers/connector/cn_queue.c +0 -1

index 75122cb..23cc87a 100644
@@ -104,7 +104,6 @@ int cn_queue_add_callback(struct cn_queue_dev *dev, char *name, struct cb_id *id
 		return -EINVAL;
 	}
 
-	cbq->nls = dev->nls;
 	cbq->seq = 0;
 	cbq->group = cbq->id.id.idx;

include/linux/connector.h +1 -3

index 7e18311..da6dd95 100644
@@ -132,15 +132,13 @@ struct cn_callback_data {
 
 struct cn_callback_entry {
 	struct list_head callback_entry;
-	struct cn_callback *cb;
 	struct work_struct work;
 	struct cn_queue_dev *pdev;
 
 	struct cn_callback_id id;
 	struct cn_callback_data data;
 
-	int seq, group;
-	struct sock *nls;
+	u32 seq, group;
 };
 
 struct cn_ctl_entry {

Signature · 1 line

1.5.3.rc7