Miscellaneous for Taco
PATCH 1/1 Miscellaneous for Taco
Last ones for now.
This patch allows you to turn off scsi_wait_scan.
drivers/scsi/Kconfig +0 -0
@@ -248,7 +248,7 @@ config SCSI_SCAN_ASYNC or async on the kernel's command line.
config SCSI_WAIT_SCAN
- tristate
+ tristate "SCSI wait scan"
default m
depends on SCSI
depends on MODULES
This patch allows you to use the USB with the taco. The taco does not have PCI so we must specifically add it.
drivers/usb/Kconfig +1 -0
@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if TACO # MIPS: default y if SOC_AU1X00 # more:
Cheers,
Sean
Quoted 3 lines · Sean MacLennan
Last ones for now.
This patch allows you to turn off
scsi_wait_scan.
You'll have to run that one via the SCSI maintainers.
Quoted 22 lines
drivers/scsi/Kconfig +1
-1@@ -248,7 +248,7 @@ config SCSI_SCAN_ASYNC or async on the kernel's command line. config SCSI_WAIT_SCAN - tristate + tristate "SCSI wait scan" default m depends on SCSI depends on MODULESThis patch allows you to use the USB with the taco. The taco does not have PCI so we must specifically add it.
drivers/usb/Kconfig +0
-0
drivers/usb/Kconfig config USB_ARCH_HAS_OHCI · line 45
Quoted 7 lines
drivers/usb/Kconfig +1
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if TACO # MIPS: default y if SOC_AU1X00 # more:
I think we should instead reference use the 440EP here, or select it from your board code. I -hate- those long lists of board specific bits hidden in driver Kconfig...
Cheers,
Ben.
Quoted 6 lines · Benjamin Herrenschmidt
Quoted 6 lines
drivers/usb/Kconfig +0
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC:
Quoted 8 lines
drivers/usb/Kconfig config USB_ARCH_HAS_OHCI · line 45
Quoted 6 lines
drivers/usb/Kconfig +1
-0default y if STB03xxx default y if PPC_MPC52xx + default y if TACO # MIPS: default y if SOC_AU1X00 # more:I think we should instead reference use the 440EP here,
I vote for adding 440EP here.
Best regards,
Stefan
Quoted 18 lines · Stefan Roese
Quoted 6 lines · Benjamin Herrenschmidt
Quoted 6 lines
drivers/usb/Kconfig +0
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC:Quoted 9 lines
drivers/usb/Kconfig config USB_ARCH_HAS_OHCI · line 45
Quoted 7 lines
drivers/usb/Kconfig +1
-0default y if STB03xxx default y if PPC_MPC52xx + default y if TACO # MIPS: default y if SOC_AU1X00 # more:I think we should instead reference use the 440EP here,
Quoted 5 lines
I vote for adding 440EP here.
Best regards,
Stefan
Ok. I thought of that, but most 440EP boards have PCI set and don't need the special option. I was worried if I put 440EP someone down the road might remove it as "extraneous". We are probably the only 440EP board with no PCI ;)
Cheers,
Sean
Quoted 4 lines · Sean MacLennan
Ok. I thought of that, but most 440EP boards have PCI set and don't need the special option. I was worried if I put 440EP someone down the road might remove it as "extraneous". We are probably the only 440EP board with no PCI ;)
Well, it's different.... PCI is an option that can be enabled ... or not by the board. In our case, the HAS_OHCI thing is just a switch to indicate that an OHCI can exist, it's not actually adding code, so it can be safely left ON whenever a 440EP processor is there, it has no bloat and won't conflict with the PCI option.
Ben.
How about just 44x?
Cheers,
Sean
drivers/usb/Kconfig +1 -0
@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if 44x # MIPS: default y if SOC_AU1X00 # more:
Quoted 10 lines · Sean MacLennan
How about just 44x?
Cheers,
Seandrivers/usb/Kconfig +0
-0
drivers/usb/Kconfig config USB_ARCH_HAS_OHCI · line 42
Quoted 4 lines
drivers/usb/Kconfig +1
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if 44x
No. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. But since your patch only touches 440EP, you should just enable OHCI for exactly this platform.
Best regards,
Stefan
Quoted 6 lines · Stefan Roese
Quoted 5 lines · Sean MacLennan
How about just 44x?
Cheers,
Sean
Quoted 13 lines
drivers/usb/Kconfig config USB_ARCH_HAS_OHCI · line 42
Quoted 9 lines
drivers/usb/Kconfig +1
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if 44xNo. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. But since your patch only touches 440EP, you should just enable OHCI for exactly this platform.
Note that the above Kconfig stuff just enabling the choice to enable OHCI, it's not enabling build of OHCI per-se.
Ben.
Quoted 20 lines · Stefan Roese
Quoted 10 lines · Sean MacLennan
How about just 44x?
Cheers,
Seandrivers/usb/Kconfig +0
-0drivers/usb/Kconfig config USB_ARCH_HAS_OHCI · line 43
Quoted 5 lines
drivers/usb/Kconfig +1
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if 44xNo. Not all 44x have OHCI built in. Currently 440EP, 440EPx and 405EZ have it. But since your patch only touches 440EP, you should just enable OHCI for exactly this platform.
Quoted 3 lines
Best regards,
Stefan
---
drivers/usb/Kconfig +1 -0
@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if 440EP # MIPS: default y if SOC_AU1X00 # more:
Quoted 1 line · On Wed, 09 Jan 2008 12:26:14 -0500 Sean MacLennan <[email protected]>…
Signed-off-by Sean MacLennan <[email protected]>
This one needs to go to the linux-usb list and David Brownell.
Although I'm not sure what the benefit here really is. You can still set this in the defconfig without adding this patch... I don't see a need to do a default.
josh
Quoted 19 lines
---
drivers/usb/Kconfig +1
-0@@ -39,6 +39,7 @@ config USB_ARCH_HAS_OHCI # PPC: default y if STB03xxx default y if PPC_MPC52xx + default y if 440EP # MIPS: default y if SOC_AU1X00 # more:_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Quoted 4 lines · Josh Boyer
On Wed, 09 Jan 2008 12:26:14 -0500
Sean MacLennan <[email protected]> wrote:
Quoted 9 lines
Quoted 2 lines
Signed-off-by Sean MacLennan <[email protected]>This one needs to go to the linux-usb list and David Brownell.
Although I'm not sure what the benefit here really is. You can still set this in the defconfig without adding this patch... I don't see a need to do a default.
Without the default, I was unable to select this option. I may have solved it the wrong way. It seems if there is no string after the tristate or boolean, you are not allowed to set the variable, it can only default. So with no default, I cannot enable this option and therefore cannot enable the ohci driver.
Again, I think the "default PCI" case catches most boards and all PCI-less, or possibly PCI-less, boards need a default.
Cheers,
Sean
Quoted 14 lines · On Wed, 09 Jan 2008 14:26:56 -0500 Sean MacLennan <[email protected]>…
Quoted 4 lines · Josh Boyer
On Wed, 09 Jan 2008 12:26:14 -0500
Sean MacLennan <[email protected]> wrote:Quoted 9 lines
Quoted 2 lines
Signed-off-by Sean MacLennan <[email protected]>This one needs to go to the linux-usb list and David Brownell.
Although I'm not sure what the benefit here really is. You can still set this in the defconfig without adding this patch... I don't see a need to do a default.
Quoted 8 lines
Without the default, I was unable to select this option. I may have solved it the wrong way. It seems if there is no string after the tristate or boolean, you are not allowed to set the variable, it can only default. So with no default, I cannot enable this option and therefore cannot enable the ohci driver.
Again, I think the "default PCI" case catches most boards and all PCI-less, or possibly PCI-less, boards need a default.
Ah, possibly. Did you try doing a 'select USB_ARCH_HAS_OHCI' in the config 440EP section of arch/powerpc/platforms/44x/Kconfig?
I'm just trying to save you some trouble. There's nothing actually wrong with your patch now, other than it has to be sent to the right maintainer.
josh
Quoted 10 lines · Josh Boyer
Ah, possibly. Did you try doing a 'select
USB_ARCH_HAS_OHCI' in the config 440EP section ofarch/powerpc/platforms/44x/Kconfig?I'm just trying to save you some trouble. There's nothing actually wrong with your patch now, other than it has to be sent to the right maintainer.
josh
That works. Thanks!
Cheers,
Sean