dlm close othercons
PATCH 1/1 dlm close othercons
This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down.
This results in the error message
"slab error in kmem_cache_destroy(): cache `dlm_conn': Can't free all objects"
and the DLM cannot be restarted without a system reboot.
See bz#428119
-------------- next part --------------
A non-text attachment was scrubbed...
Name: con-free.patch
Type: text/x-patch
Size: 352 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20080109/2e37afa7/attachment.bin>
PATCH 1/1 dlm close othercons
Hi,
Now in the -nmw git tree. Thanks,
Steve.
Quoted 13 lines · Patrick Caulfeld
This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down.
This results in the error message
"slab error inkmem_cache_destroy(): cache `dlm_conn': Can't free all objects"and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by Patrick Caulfield <[email protected]>
PATCH 1/1 dlm close othercons
In reply to Patrick CaulfeldQuoted 8 lines · Patrick Caulfeld
This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down.
This results in the error message
"slab error inkmem_cache_destroy(): cache `dlm_conn': Can't free all objects"
Quoted 6 lines
and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by Patrick Caulfield <[email protected]>
this doesn't look right...
shouldn't we free the con->other _before_ we free con?
That's what we were doing before applying all that patch set that removed the original kmem_cache_free...
Fabio
--
I'm going to make him an offer he can't refuse.
PATCH 1/1 dlm close othercons
Quoted 20 lines · Fabio M. Di Nitto
Quoted 8 lines · Patrick Caulfeld
This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down.
This results in the error message
"slab error inkmem_cache_destroy(): cache `dlm_conn': Can't free all objects"Quoted 6 lines
and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by Patrick Caulfield <[email protected]>
Quoted 7 lines
this doesn't look right...
shouldn't we free the
con->other_before_ we free con?That's what we were doing before applying all that patch set that removed the original
kmem_cache_free...
ARGH! you're right, of course. Patch to fix is attached.
Thanks Fabio, I'm glad that someone reads my patches ... I just wish it had been me ;-)
Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: free2.patch
Type: text/x-patch
Size: 428 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20080118/8a5c7c46/attachment.bin>
PATCH 1/1 dlm close othercons
Quoted 30 lines · Patrick Caulfeld
Quoted 20 lines · Fabio M. Di Nitto
Quoted 8 lines · Patrick Caulfeld
This patch addresses a problem introduced with the last round of lowcomms patches where the 'othercon' connections do not get freed when the DLM shuts down.
This results in the error message
"slab error inkmem_cache_destroy(): cache `dlm_conn': Can't free all objects"Quoted 6 lines
and the DLM cannot be restarted without a system reboot.
See bz#428119
Signed-off-by Patrick Caulfield <[email protected]>Quoted 7 lines
this doesn't look right...
shouldn't we free the
con->other_before_ we free con?That's what we were doing before applying all that patch set that removed the original
kmem_cache_free...
Quoted 9 lines
ARGH! you're right, of course. Patch to fix is attached.
Thanks Fabio, I'm glad that someone reads my patches ... I just wish it had been me ;-)
Patrick
Signed-off-by Patrick Caulfield <[email protected]>
Fabio
--
I'm going to make him an offer he can't refuse.