Skip to contentSkip to conversation

Remove superfluous preprocessor conditionals from LM73 driver

PATCH New Larry Johnson 4 participants 5 messages Jan 9, 2008 – Jan 11, 2008

Subsystems (2)
Hardware monitoring LM73 hardware monitor driver
lore
Share & tools
lore

Larry Johnson

author
#0 lore raw

PATCH 1/1 Remove superfluous preprocessor conditionals from LM73 driver

(1) Remove unused symbol "CFG_EEPROM_PAGE_WRITE_ENABLE".

(2) Use conditional Makefile.o.

Signed-off-by Larry Johnson <[email protected]>

---
Hi Stefan,

I'm resubmitting this patch, which is based off the current PPC4xx "master" branch. It may have fallen through the cracks because I botched the subject line the last time I sent it.

Best regards,
Larry

 drivers/hwmon/Makefile  |    2 +-
 drivers/hwmon/lm73.c    |    9 ---------
 include/configs/korat.h |    1 -
 3 files changed, 1 insertions(+), 11 deletions(-)
drivers/hwmon/Makefile +1 -1
index 32e3f44..065433a 100644
@@ -34,7 +34,7 @@ COBJS-y += adm1021.o
 COBJS-y += ds1621.o
 COBJS-y += ds1722.o
 COBJS-y += ds1775.o
-COBJS-y += lm73.o
+COBJS-$(CONFIG_DTT_LM73) += lm73.o
 COBJS-y += lm75.o
 COBJS-y += lm81.o
drivers/hwmon/lm73.c +0 -9
index f9ae012..db8ef66 100644
@@ -31,13 +31,6 @@
  */
 
 #include <common.h>
-
-#ifdef CONFIG_DTT_LM73
-#if !defined(CFG_EEPROM_PAGE_WRITE_ENABLE) || \
-	(CFG_EEPROM_PAGE_WRITE_BITS < 1)
-# error "CFG_EEPROM_PAGE_WRITE_ENABLE must be defined and CFG_EEPROM_PAGE_WRITE_BITS must be greater than  1 to use CONFIG_DTT_LM73"
-#endif
-
 #include <i2c.h>
 #include <dtt.h>
 

@@ -177,5 +170,3 @@ int dtt_get_temp(int sensor)
 {
 	return (dtt_read(sensor, DTT_READ_TEMP) + 0x0040) >> 7;
 } /* dtt_get_temp() */
-
-#endif /* CONFIG_DTT_LM73 */
include/configs/korat.h +0 -1
index 7d0640b..5182972 100644
@@ -156,7 +156,6 @@
 #define CFG_I2C_MULTI_EEPROMS
 #define CFG_I2C_EEPROM_ADDR	(0xa8>>1)
 #define CFG_I2C_EEPROM_ADDR_LEN 1
-#define CFG_EEPROM_PAGE_WRITE_ENABLE
 #define CFG_EEPROM_PAGE_WRITE_BITS 3
 #define CFG_EEPROM_PAGE_WRITE_DELAY_MS 10
#1 lore raw

PATCH 1/1 Remove superfluous preprocessor conditionals from LM73 driver

Quoted 5 lines · Larry Johnson

(1) Remove unused symbol "CFG_EEPROM_PAGE_WRITE_ENABLE".

(2) Use conditional Makefile.o.

Signed-off-by Larry Johnson <[email protected]>
Acked-by Stefan Roese <[email protected]>

Wolfgang, will you apply this patch directly? It doesn't really belong the 4xx repo.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH 1/1 Remove superfluous preprocessor conditionals from LM73 driver

Quoted 8 lines · Stefan Roese
Quoted 5 lines · Larry Johnson

(1) Remove unused symbol "CFG_EEPROM_PAGE_WRITE_ENABLE".

(2) Use conditional Makefile.o.

Signed-off-by Larry Johnson <[email protected]>
Acked-by Stefan Roese <[email protected]>

Thanks, it help me to prepare the kconfig for the next merge

Acked-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

Best Regards,
J.

Applied
#4 lore raw

PATCH 1/1 Remove superfluous preprocessor conditionals from LM73 driver

In reply to Larry Johnson
Quoted 5 lines · In message <[email protected]> you wrote:

(1) Remove unused symbol "CFG_EEPROM_PAGE_WRITE_ENABLE".

(2) Use conditional Makefile.o.

Signed-off-by Larry Johnson <[email protected]>

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Single tasking: Just Say No.
#3 lore raw

PATCH 1/1 Remove superfluous preprocessor conditionals from LM73 driver

In reply to Stefan Roese
Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 5 lines · Larry Johnson

(1) Remove unused symbol "CFG_EEPROM_PAGE_WRITE_ENABLE".

(2) Use conditional Makefile.o.

Signed-off-by Larry Johnson <[email protected]>
Acked-by Stefan Roese <[email protected]>

Wolfgang, will you apply this patch directly? It doesn't really belong the 4xx repo.

Done. Thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Abstainer: A weak person who yields to the temptation of denying him-
self a pleasure. A total abstainer is one who  abstains  from  every-
thing  but  abstention, and especially from inactivity in the affairs
of others.                                           - Ambrose Bierce