x86_64: move out tick_nohz_stop_sched_tick() call from the loop

PATCH Applied Hiroshi Shimamoto 2 participants 2 messages Jan 10, 2008 x86

lore

Share & tools

lore

Hiroshi Shimamoto

author

2008-01-10 03:44 UTC #0 lore raw

PATCH 1/1 x86_64: move out tick_nohz_stop_sched_tick() call from the loop

Hello,

tick_nohz_stop_sched_tick() and tick_nohz_restart_sched_tick() pair in cpu_idle() is different from 32-bit version.

From: Hiroshi Shimamoto <[email protected]>
Subject: [PATCH] x86_64: move out tick_nohz_stop_sched_tick() call from the loop

Move out tick_nohz_stop_sched_tick() call from the loop in cpu_idle same as 32-bit version.

Signed-off-by Hiroshi Shimamoto <[email protected]>

---
 arch/x86/kernel/process_64.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

arch/x86/kernel/process_64.c +1 -2

index 93ce4f3..6870208 100644
@@ -170,14 +170,13 @@ void cpu_idle(void)
 	current_thread_info()->status |= TS_POLLING;
 	/* endless idle loop with no priority at all */
 	while (1) {
+		tick_nohz_stop_sched_tick();
 		while (!need_resched()) {
 			void (*idle)(void);
 
 			if (__get_cpu_var(cpu_idle_state))
 				__get_cpu_var(cpu_idle_state) = 0;
 
-			tick_nohz_stop_sched_tick();
-
 			rmb();
 			idle = pm_idle;
 			if (!idle)

Signature · 1 line

1.5.3.6

Ingo Molnar

Applied

2008-01-10 08:02 UTC #1 lore raw

arch/x86/kernel/process_64.c void cpu_idle(void) · line 180

Quoted 13 lines · Hiroshi Shimamoto

arch/x86/kernel/process_64.c +1 -2

@@ -170,14 +170,13 @@ void cpu_idle(void)
 	current_thread_info()->status |= TS_POLLING;
 	/* endless idle loop with no priority at all */
 	while (1) {
+		tick_nohz_stop_sched_tick();
 		while (!need_resched()) {
 			void (*idle)(void);
 
 			if (__get_cpu_var(cpu_idle_state))
 				__get_cpu_var(cpu_idle_state) = 0;
 
-			tick_nohz_stop_sched_tick();
-

thanks, applied.

Ingo