Skip to contentSkip to conversation

libata-pmp: 4726 hates SRST

PATCH In review Tejun Heo 2 participants 2 messages Jan 10, 2008 libata

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata-pmp: 4726 hates SRST

4726 hates SRST even on non-config ports. Don't use it.

Signed-off-by Tejun Heo <[email protected]>
---
 drivers/ata/libata-pmp.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/ata/libata-pmp.c +5 -7
index c0c4dbc..caef2bb 100644
@@ -495,14 +495,12 @@ static void sata_pmp_quirks(struct ata_port *ap)
 			/* SError.N need a kick in the ass to get working */
 			link->flags |= ATA_LFLAG_HRST_TO_RESUME;
 
-			/* class code report is unreliable */
-			if (link->pmp < 5)
-				link->flags |= ATA_LFLAG_ASSUME_ATA;
-
-			/* The config device, which can be either at
-			 * port 0 or 5, locks up on SRST.
+			/* Class code report is unreliable and SRST
+			 * times out under certain configurations.
+			 * Config device can be at port 0 or 5 and
+			 * locks up on SRST.
 			 */
-			if (link->pmp == 0 || link->pmp == 5)
+			if (link->pmp <= 5)
 				link->flags |= ATA_LFLAG_NO_SRST |
 					       ATA_LFLAG_ASSUME_ATA;
#1 lore raw
Quoted 6 lines · Tejun Heo

4726 hates SRST even on non-config ports. Don't use it.

Signed-off-by Tejun Heo <[email protected]>
---
 drivers/ata/libata-pmp.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

applied this and propagate timeout patch