: Prevent nesting macvlan devices
Subsystems (2)
[MACVLAN]: Prevent nesting macvlan devices
Don't allow to nest macvlan devices since it will cause lockdep warnings and isn't really useful for anything.
Signed-off-by Patrick McHardy <[email protected]>
---
commit 80a76fbde679793a17482a3dd842386801fca66b
tree 07f67e78ac0ae505a5de81e7e770a1b7d597f120
parent 4d14fded63dcaf9d5dcf78e2a8ea3f5de2c29eb9
author Patrick McHardy <[email protected]> Thu, 10 Jan 2008 16:25:01 +0100 committer Patrick McHardy <[email protected]> Thu, 10 Jan 2008 16:25:01 +0100
drivers/net/macvlan.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)
drivers/net/macvlan.c +7 -0
@@ -384,6 +384,13 @@ static int macvlan_newlink(struct net_device *dev,if (lowerdev ==NULL )return -ENODEV ; +/* Don't allow macvlans on top of other macvlans - its not really +* wrong, but lockdep can't handle it and its not useful for anything +* you couldn't do directly on top of the real device. +*/ +if (lowerdev->rtnl_link_ops == dev->rtnl_link_ops) +return -ENODEV ; +if (!tb[IFLA_MTU ]) dev->mtu = lowerdev->mtu;else if (dev->mtu > lowerdev->mtu)
From: Patrick McHardy <[email protected]>
Date: Thu, 10 Jan 2008 16:32:38 +0100
Quoted 6 lines
[MACVLAN]: Prevent nesting macvlan devices
Don't allow to nest macvlan devices since it will cause lockdep warnings and isn't really useful for anything.
Signed-off-by Patrick McHardy <[email protected]>
Applied.