Skip to contentSkip to conversation

lapi/syscalls: Add epoll_create for aarch64.in

PATCH zhaogongyi 2 participants 2 messages Oct 27, 2021

lore
Share & tools
lore

zhaogongyi

author
#0 lore raw

Hi,

Quoted 42 lines
Quoted 5 lines · zhaogongyi

Hi,

Quoted 2 lines

On Tue, Oct 26, 2021 at 9:49 AM Zhao Gongyi

<[email protected]>

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines · wrote:

Add epoll_create for aarch64.in and modify the value of epoll_ctl for aarch64.in. Otherwise, the testcase epoll_create01/epoll_create02 will fail.

---
 include/lapi/syscalls/aarch64.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
include/lapi/syscalls/aarch64.in +0 -0
index a47185954..e9023a1d0 100644
@@ -19,7 +19,6 @@ getcwd 17
Quoted 8 lines

include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 perf_event_open

Quoted 8 lines
include/lapi/syscalls/aarch64.in +0 -1
 lookup_dcookie 18
 eventfd2 19
 epoll_create1 20
-epoll_ctl 21
 epoll_pwait 22
 dup 23
 dup3 24
@@ -243,6 +242,8 @@ rt_tgsigqueueinfo 240  perf_event_open

241

Quoted 7 lines
Quoted 6 lines

include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 perf_event_open · line 245

Quoted 4 lines
include/lapi/syscalls/aarch64.in +2 -0
 accept4 242
 recvmmsg 243
+epoll_create 250
+epoll_ctl 251

These values are for 32 bit only syscalls. Won't this break 64 bit?

Quoted 5 lines
Quoted 1 line

Yes, these values are for 32 bit only syscalls, the syscall epoll_create is

not support for 64bit arm64.

Right, adding epoll_create is OK, but changing epoll_ctl would break 64bit if there were any users of __NR_epoll_ctl.

If we do not consider the running of 32bit program on arm64, we need to remove __NR_epoll_ctl.

And the testcase using __NR_epoll_ctl will fail, is it a problem to be resolved?

Quoted 28 lines
Quoted 3 lines

Reference to man 2 epoll_create, we can see that

epoll_create/epoll_create1 are supported If only we include the header file sys/epoll.h.

Quoted 2 lines

Is it better that we call epoll_create replace to syscall

__NR_epoll_create since some plateform not support it?

I think so. We already use epoll_create() in other tests, so this looks like simplest solution for all arches.

Quoted 16 lines

Thanks for you review!

Quoted 11 lines
Quoted 11 lines
include/lapi/syscalls/aarch64.in +0 -1
 wait4 260
 prlimit64 261
 fanotify_init 262
--

2.17.1

--
Mailing list info: https://lists.linux.it/listinfo/ltp

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw
Quoted 48 lines · zhaogongyi

Hi,

Quoted 43 lines
Quoted 5 lines · zhaogongyi

Hi,

Quoted 2 lines

On Tue, Oct 26, 2021 at 9:49 AM Zhao Gongyi

<[email protected]>

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines · wrote:

Add epoll_create for aarch64.in and modify the value of epoll_ctl for aarch64.in. Otherwise, the testcase epoll_create01/epoll_create02 will fail.

---
 include/lapi/syscalls/aarch64.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
include/lapi/syscalls/aarch64.in +0 -0
index a47185954..e9023a1d0 100644
@@ -19,7 +19,6 @@ getcwd 17
Quoted 8 lines

include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 perf_event_open

Quoted 8 lines
include/lapi/syscalls/aarch64.in +0 -1
 lookup_dcookie 18
 eventfd2 19
 epoll_create1 20
-epoll_ctl 21
 epoll_pwait 22
 dup 23
 dup3 24
@@ -243,6 +242,8 @@ rt_tgsigqueueinfo 240  perf_event_open

241

Quoted 8 lines
Quoted 6 lines

include/lapi/syscalls/aarch64.in rt_tgsigqueueinfo 240 perf_event_open · line 245

Quoted 4 lines
include/lapi/syscalls/aarch64.in +2 -0
 accept4 242
 recvmmsg 243
+epoll_create 250
+epoll_ctl 251

These values are for 32 bit only syscalls. Won't this break 64 bit?

Yes, these values are for 32 bit only syscalls, the syscall epoll_create is

Quoted 8 lines
Quoted 4 lines

not support for 64bit arm64.

Right, adding epoll_create is OK, but changing epoll_ctl would break 64bit if there were any users of __NR_epoll_ctl.

If we do not consider the running of 32bit program on arm64, we need to remove __NR_epoll_ctl.

And the testcase using __NR_epoll_ctl will fail, is it a problem to be resolved?

There are no testcases currently using __NR_epoll_ctl, but to avoid this potential
issues in future, we can remove it. Existing testcases use libc epoll_ctl().

Quoted 30 lines
Quoted 29 lines
Quoted 4 lines

Reference to man 2 epoll_create, we can see that

epoll_create/epoll_create1 are supported If only we include the header file sys/epoll.h.

Quoted 2 lines

Is it better that we call epoll_create replace to syscall

__NR_epoll_create since some plateform not support it?

I think so. We already use epoll_create() in other tests, so this looks like simplest solution for all arches.

Quoted 16 lines

Thanks for you review!

Quoted 11 lines
Quoted 11 lines
include/lapi/syscalls/aarch64.in +0 -1
 wait4 260
 prlimit64 261
 fanotify_init 262
--

2.17.1

--
Mailing list info: https://lists.linux.it/listinfo/ltp

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp