janitor: revert accidental type change
PATCH 1/1 janitor: revert accidental type change
While trying to reduce the warning noise (to identify warnings of homebrewed patches), I also came across this bogus but fortunately harmless type change in bdrv_commit. Fix below.
Jan
qemu/block.c +1 -1
@@ -460,7 +460,7 @@ int bdrv_commit(BlockDriverState *bs)BlockDriver *drv = bs->drv;int64_t i, total_sectors;int n, j; -unsigned char *sector[512 ]; +unsigned char sector[512 ];if (!drv)return -ENOMEDIUM ;
Signature · 7 lines
Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines · Jan Kiszka
While trying to reduce the warning noise (to identify warnings of homebrewed patches), I also came across this bogus but fortunately harmless type change in
bdrv_commit. Fix below.Jan
This has already been reported.
Please apply, Avi.
I'm working on a patch to be able to use snapshot=on and cache=off together, but while I'm fighting against AIO (I've an incomprehensible EINVAL) you should apply this fix.
Laurent
Quoted 7 lines
Index:
kvm-userspace/qemu/block.c
===================================================================
qemu/block.c int bdrv_commit(BlockDriverState *bs) · line 466
Quoted 8 lines
qemu/block.c +1
-1@@ -460,7 +460,7 @@ int bdrv_commit(BlockDriverState *bs)BlockDriver *drv = bs->drv;int64_t i, total_sectors;int n, j; -unsigned char *sector[512 ]; +unsigned char sector[512 ];if (!drv)return -ENOMEDIUM ;
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/kvm-devel
Quoted 3 lines · Jan Kiszka
While trying to reduce the warning noise (to identify warnings of homebrewed patches), I also came across this bogus but fortunately harmless type change in
bdrv_commit. Fix below
the same fix was proposed before in :
http://www.mail-archive.com/[email protected]/msg11246.html
but as you can see in that thread, a more complete change will be needed to cover for alignment issues when using direct IO (cache=off)
Carlo
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Avi Kivity
AppliedQuoted 5 lines · Jan Kiszka
While trying to reduce the warning noise (to identify warnings of homebrewed patches), I also came across this bogus but fortunately harmless type change in
bdrv_commit. Fix below.
Applied, thanks.
Signature · 7 lines
error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/