Skip to contentSkip to conversation

Sending IOCTLs from 32-bit userland to 64-bit Kernel module

DISCUSSION Yoav Artzi 4 participants 4 messages Jan 29, 2008

lore
Share & tools
lore

Yoav Artzi

author
#0 lore raw

Hi,

I have a 32-bit user land application which sends an IOCTL to a 64-bit Kernel module. I have a few different cmd codes that I can send through the IOCTL. For some reason I seem to always get the same IOCTL cmd from user land, no matter what the ioctl() call is given. This cmd code that I get has some bytes (W/R and the module code) that are OK, but the rest is just garbage or zeros. This was originally a 32-bit system, and we are no converting the Kernel module to 64-bit, so maybe there's something special for 32-64 communication that miss.

I am working on Linux Kernel v2.6.18.

Thanks

#1 lore raw
Quoted 11 lines · Yoav Artzi

Hi,

I have a 32-bit user land application which sends an IOCTL to a 64-bit Kernel module. I have a few different cmd codes that I can send through the IOCTL. For some reason I seem to always get the same IOCTL cmd from user land, no matter what the ioctl() call is given. This cmd code that I get has some bytes (W/R and the module code) that are OK, but the rest is just garbage or zeros. This was originally a 32-bit system, and we are no converting the Kernel module to 64-bit, so maybe there's something special for 32-64 communication that miss.

Please see numerous examples in kernel source, in many files named compat_ioctl.c. If your ioctls uses structures with fields that have different sizes in 32- and 64-bit worlds (most notable int, various enums etc), there should be corresponding translation layer as in those examples. If it's your kernel code, that is. (And try to avoid such types there, use u32 or u64 and the like that explicitly specify size).

Another possible problem is different alignment of fields in 64- vs 32-bits worlds.

Quoted 1 line

I am working on Linux Kernel v2.6.18.

If the kernel side isn't your code, the chances are quite high that this problem has long been fixed in more recent kernels.

/mjt

#2 lore raw
Quoted 2 lines · Michael Tokarev

(And try to avoid such types there, use u32 or u64 and the like that explicitly specify size).

... and don't pass pointers to _IOC macros as well.

#3 lore raw
In reply to Yoav Artzi
Quoted 11 lines · Yoav Artzi

Hi,

I have a 32-bit user land application which sends an IOCTL to a 64-bit Kernel module. I have a few different cmd codes that I can send through the IOCTL. For some reason I seem to always get the same IOCTL cmd from user land, no matter what the ioctl() call is given. This cmd code that I get has some bytes (W/R and the module code) that are OK, but the rest is just garbage or zeros. This was originally a 32-bit system, and we are no converting the Kernel module to 64-bit, so maybe there's something special for 32-64 communication that miss.

In x86_64 kernel there is an adaptation layer that translates 32-bit ioctl:s to kernel internal 64-bit ones, when absolutely necessary.

If you do not need to pass pointers in your ioctl(), then typedef:in passed parameters with explicite size may save you from lots of trouble:

   struct cpioctl {
        long     var;   /* definite trouble 32-bit vs. 64-bit */
        uint32_t var2;  /* no troubles... */
        uint64_t var3;
   };

After that, the only issue is that 32-bit user space ioctl() passes a pointer that is valid in 32-bit space only, bit that is handled by the common layer without need to make specific adaptation routine.

.. however if the structure has pointer to elsewere in memory, then things get complicated really fast.

Quoted 2 lines

I am working on Linux Kernel v2.6.18.
Thanks