Skip to contentSkip to conversation

x86: PAE swapper_pg_dir needs to be page-sized

PATCH Jeremy Fitzhardinge 3 participants 4 messages Jan 31, 2008 – Feb 1, 2008 x86

lore
Share & tools
lore
#0 lore raw

Xen currently needs swapper_pg_dir page aligned and sized. This fixes the second part of that...

---
arch/x86/kernel/head_32.S | 1 +

1 file changed, 1 insertion(+)

===================================================================

arch/x86/kernel/head_32.S +0 -0
@@ -640,6 +640,7 @@
# else
#  error "Kernel PMDs should be 1, 2 or 3"
# endif
+	.align PAGE_SIZE_asm		/* needs to be page-sized too */
#endif

.data

Acked-by
#1 lore raw
Quoted 4 lines · Jeremy Fitzhardinge

Xen currently needs swapper_pg_dir page aligned and sized. This fixes the second part of that...

Quoted 18 lines
---
 arch/x86/kernel/head_32.S |    1 +
 1 file changed, 1 insertion(+)

===================================================================

arch/x86/kernel/head_32.S +1 -0
@@ -640,6 +640,7 @@
 # else
 #  error "Kernel PMDs should be 1, 2 or 3"
 # endif
+	.align PAGE_SIZE_asm		/* needs to be page-sized too */
 #endif
 
 .data
Signature · 3 lines
Ian Campbell

Yow!  Am I in Milwaukee?
#2 lore raw
Quoted 10 lines · Ian Campbell
Quoted 4 lines · Jeremy Fitzhardinge

Xen currently needs swapper_pg_dir page aligned and sized. This fixes the second part of that...

Review

Quoted 2 lines
 # endif
(quoted diff) +1 -0
+	.align PAGE_SIZE_asm		/* needs to be page-sized too */

thanks, applied. I'm wondering, where did we break that?

Ingo

#3 lore raw
Quoted 2 lines · Ingo Molnar

thanks, applied. I'm wondering, where did we break that?

In the "PAE from boot" patch, I would guess.

J