Skip to contentSkip to conversation

IPV4: fix compile error building without CONFIG_FS_PROC

PATCH Applied Li Zefan 3 participants 5 messages Feb 3, 2008 – Feb 5, 2008

Subsystems (2)
lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 IPV4: fix compile error building without CONFIG_FS_PROC

compile error building without CONFIG_FS_PROC.

net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_ init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_ exit'

---
 include/net/ip_fib.h |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
include/net/ip_fib.h +8 -0
index 90d1175..af5e985 100644
@@ -267,5 +267,13 @@ static inline void fib_res_put(struct fib_result *res)
 extern int __net_init  fib_proc_init(struct net *net);
 extern void __net_exit fib_proc_exit(struct net *net);
 #endif
+static inline int fib_proc_init(struct net *net)
+{
+	return 0;
+}
+static inline int fib_proc_exit(struct net *net)
+{
+	return 0;
+}
 
 #endif  /* _NET_FIB_H */
Signature · 1 line
1.5.4.rc3
author
#1 lore raw

compile error building without CONFIG_FS_PROC.

net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_ init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_ exit'

---

The exit method should have no return values...

---
 include/net/ip_fib.h |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
include/net/ip_fib.h +7 -0
index 90d1175..69393e3 100644
@@ -267,5 +267,12 @@ static inline void fib_res_put(struct fib_result *res)
 extern int __net_init  fib_proc_init(struct net *net);
 extern void __net_exit fib_proc_exit(struct net *net);
 #endif
+static inline int fib_proc_init(struct net *net)
+{
+	return 0;
+}
+static inline void fib_proc_exit(struct net *net)
+{
+}
 
 #endif  /* _NET_FIB_H */
Signature · 1 line
1.5.4.rc3
author
#3 lore raw
Quoted 11 lines · YOSHIFUJI Hideaki

In article <[email protected]> (at Mon, 04 Feb 2008 08:47:29 +0800), Li Zefan <[email protected]> says:

Quoted 1 line

compile error building without CONFIG_FS_PROC.

:

Quoted 1 line

The exit method should have no return values...

Have you really tested this with CONFIG_FS_PROC?

--yoshfuji

Oops, shame on me, what a silly patch... :( I tested it without CONFIG_PROC_PS, but didn't test it with CONFIG_PROC_FS.

Now I've tested the new patch both with and without CONFIG_PROC_FS.

---

compile error building without CONFIG_FS_PROC:

net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_ init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_ exit'

---
 include/net/ip_fib.h |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
include/net/ip_fib.h +8 -0
index 90d1175..8b12667 100644
@@ -266,6 +266,14 @@ static inline void fib_res_put(struct fib_result *res)
 #ifdef CONFIG_PROC_FS
 extern int __net_init  fib_proc_init(struct net *net);
 extern void __net_exit fib_proc_exit(struct net *net);
+#else
+static inline int fib_proc_init(struct net *net)
+{
+	return 0;
+}
+static inline void fib_proc_exit(struct net *net)
+{
+}
 #endif
 
 #endif  /* _NET_FIB_H */
Signature · 1 line
1.5.4.rc3
maintainer Applied
#4 lore raw

From: Li Zefan <[email protected]>
Date: Mon, 04 Feb 2008 11:16:24 +0800

Quoted 10 lines

compile error building without CONFIG_FS_PROC:

net/ipv4/fib_frontend.c: In function 'fib_net_init':
net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_ init'
net/ipv4/fib_frontend.c: In function 'fib_net_exit':
net/ipv4/fib_frontend.c:1047: error: implicit declaration of function 'fib_proc_ exit'

Applied, thanks.