Build failure with 2.6.24-mm1
A message that is not in the archive (sent off-list or not yet received): [email protected]
* Balbir Singh <[email protected]> [2008-02-04 15:35:09]:
I just saw the following build failure on a power machine.
In file included from include/acpi/platform/acenv.h:140,
from include/acpi/acpi.h:54,
from include/acpi/acpi_bus.h:31,
from drivers/pci/pcie/aspm.c:20:include/acpi/platform/aclinux.h:59:22: error: asm/acpi.h: No such file or directory In file included from include/acpi/platform/aclinux.h:120,
from include/acpi/platform/acenv.h:140,
from include/acpi/acpi.h:54,
from include/acpi/acpi_bus.h:31,
from drivers/pci/pcie/aspm.c:20:include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64'include/acpi/actypes.h:131: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64'include/acpi/actypes.h:753: error: expected ')' before '*' token include/acpi/actypes.h:756: error: expected ')' before '*' token
In file included from include/acpi/acpi.h:61,
from include/acpi/acpi_bus.h:31,
from drivers/pci/pcie/aspm.c:20:include/acpi/acpiosxf.h:179: error: expected declaration specifiers or '...' before 'acpi_osd_handler'include/acpi/acpiosxf.h:183: error: expected declaration specifiers or '...' before 'acpi_osd_handler'include/acpi/acpiosxf.h:192: error: expected declaration specifiers or '...' before 'acpi_osd_exec_callback'
make[3]: *** [drivers/pci/pcie/aspm.o] Error 1
make[2]: *** [drivers/pci/pcie] Error 2
make[2]: *** Waiting for unfinished jobs....
CC drivers/ps3/ps3-vuart.o
CC net/netlink/attr.o
make[1]: *** [drivers/pci] Error 2
make[1]: *** Waiting for unfinished jobs..
The following config option is responsible for the build failure
config PCIEASPM
bool "PCI Express ASPM support(Experimental)"
depends on PCI && EXPERIMENTAL && PCIEPORTBUS
default y
help
This enables PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supports state L0/L0s/L1.
When in doubt, say N.
Here's a probable fix for the problem.
Make the build of drivers/pci/pcie/aspm.c depend on ACPI.
NOTE, the patch has not been tested. The dependency on ACPI might be wrong, but setting it to default "y" caused the build on my powerpc box to break.
---
drivers/pci/pcie/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pcie/Kconfig renamed from drivers/pci/pcie/Kconfig~fix-mm-ppc-build +1 -1
@@ -32,7 +32,7 @@ source "drivers/pci/pcie/aer/Kconfig" # config PCIEASPM bool "PCI Express ASPM support(Experimental)" - depends on PCI && EXPERIMENTAL && PCIEPORTBUS + depends on PCI && EXPERIMENTAL && PCIEPORTBUS && ACPI default y help This enables PCI Express ASPM (Active State Power Management) and
_
Signature · 4 lines
Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL
Quoted 67 lines · On Mon, 4 Feb 2008 15:37:43 +0530 Balbir Singh <[email protected]>…
* Balbir Singh <[email protected]> [2008-02-04 15:35:09]:
I just saw the following build failure on a power machine.
In file included from
include/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
frominclude/acpi/acpi_bus.h:31,
fromdrivers/pci/pcie/aspm.c:20:include/acpi/platform/aclinux.h:59:22: error:asm/acpi.h: No such file or directory In file included frominclude/acpi/platform/aclinux.h:120,
frominclude/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
frominclude/acpi/acpi_bus.h:31,
fromdrivers/pci/pcie/aspm.c:20:include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64'include/acpi/actypes.h:131: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64'include/acpi/actypes.h:753: error: expected ')' before '*' tokeninclude/acpi/actypes.h:756: error: expected ')' before '*' token
In file included frominclude/acpi/acpi.h:61,
frominclude/acpi/acpi_bus.h:31,
fromdrivers/pci/pcie/aspm.c:20:include/acpi/acpiosxf.h:179: error: expected declaration specifiers or '...' before 'acpi_osd_handler'include/acpi/acpiosxf.h:183: error: expected declaration specifiers or '...' before 'acpi_osd_handler'include/acpi/acpiosxf.h:192: error: expected declaration specifiers or '...' before 'acpi_osd_exec_callback'
make[3]: *** [drivers/pci/pcie/aspm.o] Error 1
make[2]: *** [drivers/pci/pcie] Error 2
make[2]: *** Waiting for unfinished jobs....
CCdrivers/ps3/ps3-vuart.o
CCnet/netlink/attr.o
make[1]: *** [drivers/pci] Error 2
make[1]: *** Waiting for unfinished jobs..The following config option is responsible for the build failure
config PCIEASPM
bool "PCI Express ASPM support(Experimental)"
depends on PCI && EXPERIMENTAL && PCIEPORTBUS
default y
help
This enables PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supports state L0/L0s/L1.When in doubt, say N.
Here's a probable fix for the problem.
Make the build of
drivers/pci/pcie/aspm.cdepend on ACPI.NOTE, the patch has not been tested. The dependency on ACPI might be wrong, but setting it to default "y" caused the build on my powerpc box to break.
Signed-off-by Balbir Singh <[email protected]>---
drivers/pci/pcie/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff -puN
drivers/pci/pcie/Kconfig~fix-mm-ppc-builddrivers/pci/pcie/Kconfig
drivers/pci/pcie/Kconfig source "drivers/pci/pcie/aer/Kconfig" · line 38
Quoted 8 lines
drivers/pci/pcie/Kconfig renamed from drivers/pci/pcie/Kconfig~fix-mm-ppc-build +1
-1@@ -32,7 +32,7 @@ source "drivers/pci/pcie/aer/Kconfig" # config PCIEASPM bool "PCI Express ASPM support(Experimental)" - depends on PCI && EXPERIMENTAL && PCIEPORTBUS + depends on PCI && EXPERIMENTAL && PCIEPORTBUS && ACPI default y help This enables PCI Express ASPM (Active State Power Management) and
Thanks. I think Greg is going to revert PCIEASPM altogether?
Quoted 65 lines · Andrew Morton
Quoted 63 lines · On Mon, 4 Feb 2008 15:37:43 +0530 Balbir Singh <[email protected]>…
* Balbir Singh <[email protected]> [2008-02-04 15:35:09]:
I just saw the following build failure on a power machine.
In file included from
include/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
frominclude/acpi/acpi_bus.h:31,
fromdrivers/pci/pcie/aspm.c:20:include/acpi/platform/aclinux.h:59:22: error:asm/acpi.h: No such file or directory In file included frominclude/acpi/platform/aclinux.h:120,
frominclude/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
frominclude/acpi/acpi_bus.h:31,
fromdrivers/pci/pcie/aspm.c:20:include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64'include/acpi/actypes.h:131: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64'include/acpi/actypes.h:753: error: expected ')' before '*' tokeninclude/acpi/actypes.h:756: error: expected ')' before '*' token
In file included frominclude/acpi/acpi.h:61,
frominclude/acpi/acpi_bus.h:31,
fromdrivers/pci/pcie/aspm.c:20:include/acpi/acpiosxf.h:179: error: expected declaration specifiers or '...' before 'acpi_osd_handler'include/acpi/acpiosxf.h:183: error: expected declaration specifiers or '...' before 'acpi_osd_handler'include/acpi/acpiosxf.h:192: error: expected declaration specifiers or '...' before 'acpi_osd_exec_callback'
make[3]: *** [drivers/pci/pcie/aspm.o] Error 1
make[2]: *** [drivers/pci/pcie] Error 2
make[2]: *** Waiting for unfinished jobs....
CCdrivers/ps3/ps3-vuart.o
CCnet/netlink/attr.o
make[1]: *** [drivers/pci] Error 2
make[1]: *** Waiting for unfinished jobs..The following config option is responsible for the build failure
config PCIEASPM
bool "PCI Express ASPM support(Experimental)"
depends on PCI && EXPERIMENTAL && PCIEPORTBUS
default y
help
This enables PCI Express ASPM (Active State Power Management) and Clock Power Management. ASPM supports state L0/L0s/L1.When in doubt, say N.
Here's a probable fix for the problem.
Make the build of
drivers/pci/pcie/aspm.cdepend on ACPI.NOTE, the patch has not been tested. The dependency on ACPI might be wrong, but setting it to default "y" caused the build on my powerpc box to break.
Signed-off-by Balbir Singh <[email protected]>---
drivers/pci/pcie/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
drivers/pci/pcie/Kconfig source "drivers/pci/pcie/aer/Kconfig" · line 38
Quoted 12 lines
diff -puN
drivers/pci/pcie/Kconfig~fix-mm-ppc-builddrivers/pci/pcie/Kconfigdrivers/pci/pcie/Kconfig renamed from drivers/pci/pcie/Kconfig~fix-mm-ppc-build +1
-1@@ -32,7 +32,7 @@ source "drivers/pci/pcie/aer/Kconfig" # config PCIEASPM bool "PCI Express ASPM support(Experimental)" - depends on PCI && EXPERIMENTAL && PCIEPORTBUS + depends on PCI && EXPERIMENTAL && PCIEPORTBUS && ACPI default y help This enables PCI Express ASPM (Active State Power Management) andThanks. I think Greg is going to revert PCIEASPM altogether?
Greg did, hopefully Linus will pull the changes soon...
thanks,
greg k-h