Skip to contentSkip to conversation

duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'

PATCH New Roel kluin 1 participant 1 message Feb 4, 2008 ACPI

lore
Share & tools
lore

Roel kluin

author
#0 lore raw

PATCH 1/1 duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'

in drivers/misc/thinkpad_acpi.c, lines 4137-4142 it reads:

/* safety net should the EC not support AUTO
* or FULLSPEED mode bits and just ignore them */
if (level & TP_EC_FAN_FULLSPEED)
level |= 7; /* safety min speed 7 */
else if (level & TP_EC_FAN_FULLSPEED)
level |= 4; /* safety min speed 4 */

note the nonsense duplicate test 'if (level & TP_EC_FAN_FULLSPEED)'. should this be changed to:

                if (level & TP_EC_FAN_FULLSPEED)
                        level |= 7;     /* safety min speed 7 */
                else
                        level |= 4;     /* safety min speed 4 */

or maybe

if (level & TP_EC_FAN_FULLSPEED)
level |= 7; /* safety min speed 7 */
if (level & TP_EC_FAN_FULLSPEED)
level |= 4; /* safety min speed 4 */

?