Skip to contentSkip to conversation

BUG in changeset 7157?

linux-dvb Mauro Carvalho Chehab 1 participant 1 message Feb 6, 2008 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore

Mauro Carvalho Chehab

author
#1 lore raw
In reply to a message not in the archive
Quoted 16 lines · On Tue, 05 Feb 2008 23:44:31 +0100 e9hack <[email protected]> wrote:

Hi,

compiling of the current HG tree fails on linux 2.6.24. I think it is a bug in changeset 7157:

v4l/compat.h Tue Feb 05 11:21:32 2008 -0200 renamed from v4l/compat.h Tue Feb 05 07:37:21 2008 +0000 +4 -0
@@ -497,6 +497,10 @@ do { \
 #ifndef BIT_MASK
 # define BIT_MASK(nr) (1UL << ((nr) % BITS_PER_LONG))
 # define BIT_WORD(nr) ((nr) / BITS_PER_LONG)
+
+#define i2c_verify_client(dev) \
+ ((dev->bus == &i2c_bus_type) ? to_i2c_client(dev) : NULL)
+
 #endif
Quoted 3 lines

The definition of i2c_verify_client() should not be inside #ifndef BIT_MASK / #endif. The variable i2c_bus_type is only public on 2.6.23.x (maybe also on earlier versions) but not on 2.6.24. The following patch does fix the problem on 2.6.24 for me:

Committed, thanks!

Cheers,
Mauro

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb