flow: reorder "struct flow_cache_entry" and remove SLAB_HWCACHE_ALIGN
Subsystems (2)
1) We can shrink sizeof(struct flow_cache_entry) by 8 bytes on 64bit arches.
2) No need to align these structures to hardware cache lines, this only waste ram for very litle gain.
Signed-off-by Eric Dumazet <[email protected]>
net/core/flow.c +2 -2
@@ -30,8 +30,8 @@ struct flow_cache_entry {struct flow_cache_entry *next;u16 family;u8 dir; -struct flowi key;u32 genid; +struct flowi key;void *object;atomic_t *object_ref; };
@@ -346,7 +346,7 @@ static int __init flow_cache_init(void) flow_cachep =kmem_cache_create ("flow_cache" ,sizeof (struct flow_cache_entry ), -0 ,SLAB_HWCACHE_ALIGN |SLAB_PANIC , +0 ,SLAB_PANIC ,NULL ); flow_hash_shift =10 ; flow_lwm =2 * flow_hash_size;
From: Eric Dumazet <[email protected]>
Date: Fri, 08 Feb 2008 08:12:49 +0100
Quoted 5 lines
1) We can shrink
sizeof(struct flow_cache_entry)by 8 bytes on 64bit arches.
2) No need to align these structures to hardware cache lines, this only waste ram for very litle gain.Signed-off-by Eric Dumazet <[email protected]>
Applied, thanks Eric.