Skip to contentSkip to conversation

ROUTE: remove unecessary alignment

DECNET Applied Eric Dumazet 2 participants 2 messages Feb 8, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Same alignment requirement was removed on IP route cache in the past.

This alignment actually has bad effect on 32 bit arches, uniprocessor, since sizeof(dn_rt_hash_bucket) is forced to 8 bytes instead of 4.

net/decnet/dn_route.c +1 -1
index 31be29b..9dc0abb 100644
@@ -94,7 +94,7 @@ struct dn_rt_hash_bucket
 {
 	struct dn_route *chain;
 	spinlock_t lock;
-} __attribute__((__aligned__(8)));
+};
 
 extern struct neigh_table dn_neigh_table;
 
maintainer Applied
#1 lore raw

From: Eric Dumazet <[email protected]>
Date: Fri, 08 Feb 2008 08:21:06 +0100

Quoted 6 lines

Same alignment requirement was removed on IP route cache in the past.

This alignment actually has bad effect on 32 bit arches, uniprocessor, since sizeof(dn_rt_hash_bucket) is forced to 8 bytes instead of 4.

Applied, anyone who shows love for DecNET deserves some love in return :-)