: Remove duplicate assignation in dma_skb_copy_datagram_iovec
PATCH 1/1 : Remove duplicate assignation in dma_skb_copy_datagram_iovec
[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec
No need to compute copy twice in the frags loop in dma_skb_copy_datagram_iovec().
--- user_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/user_dma.c +1 -1
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan, end = start +skb_shinfo (skb)->frags[i].size; copy = end - offset; -if ((copy = end - offset) >0 ) { +if (copy >0 ) {skb_frag_t *frag = &skb_shinfo (skb)->frags[i];struct page *page = frag->page;
Quoted 6 lines · Brice Goglin
[I/OAT]: Remove duplicate assignation in
dma_skb_copy_datagram_iovecNo need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().Signed-off-by Brice Goglin <[email protected]>
Thanks, I'll push this along.
--
Dan
Quoted 24 lines
-----Original Message-----
From: Brice Goglin [mailto:[email protected]]
Sent: Wednesday, February 13, 2008 1:05 PM
To: Nelson, Shannon; Williams, Dan J
Cc: Leech, Christopher; LKML
Subject: [PATCH][I/OAT]: Remove duplicate assignation indma_skb_copy_datagram_iovec[I/OAT]: Remove duplicate assignation in
dma_skb_copy_datagram_iovecNo need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().Signed-off-by Brice Goglin <[email protected]>---
user_dma.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)net/core/user_dma.c +0
-0
net/core/user_dma.c int dma_skb_copy_datagram_iovec(struct · line 81
Quoted 8 lines
net/core/user_dma.c +1
-1@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(structdma_chan *chan, end = start +skb_shinfo (skb)->frags[i].size; copy = end - offset; -if ((copy = end - offset) >0 ) { +if (copy >0 ) {skb_frag_t *frag = &skb_shinfo (skb)->frags[i];struct page *page = frag->page;