Skip to contentSkip to conversation

latencytop: fix kernel panic while reading latency proc file

PATCH New Hiroshi Shimamoto 1 participant 1 message Feb 14, 2008 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 latencytop: fix kernel panic while reading latency proc file

From: Hiroshi Shimamoto <[email protected]>

Reading /proc/<pid>/latency or /proc/<pid>/task/<tid>/latency could cause NULL pointer dereference.

In lstats_open(), get_proc_task() can return NULL, in which case the kernel will oops at lstats_show_proc() because m->private is NULL.

When get_proc_task() returns NULL, the kernel should return -ENOENT.

This can be reproduced by the following script.
while :
do
date
bash -c 'ls > ls.$$' &
pid=$!
cat /proc/$pid/latency &
cat /proc/$pid/latency &
cat /proc/$pid/latency &
cat /proc/$pid/latency
done

---
 fs/proc/base.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/proc/base.c +2 -0
index 7c6b4ec..1710b03 100644
@@ -350,6 +350,8 @@ static int lstats_open(struct inode *inode, struct file *file)
 	struct seq_file *m;
 	struct task_struct *task = get_proc_task(inode);
 
+	if (!task)
+		return -ENOENT;
 	ret = single_open(file, lstats_show_proc, NULL);
 	if (!ret) {
 		m = file->private_data;
Signature · 1 line
1.5.3.8