Skip to contentSkip to conversation

cgroup: remove dead code in cgroup_get_rootdir()

PATCH In review Li Zefan 3 participants 3 messages Feb 18, 2008 – Feb 21, 2008 1 message not in the archive

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 7/7 cgroup: remove dead code in cgroup_get_rootdir()

Signed-off-by Li Zefan <[email protected]>
---
 kernel/cgroup.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
kernel/cgroup.c +0 -1
index 71cf961..879a056 100644
@@ -926,7 +926,6 @@ static int cgroup_get_rootdir(struct super_block *sb)
 	if (!inode)
 		return -ENOMEM;
 
-	inode->i_op = &simple_dir_inode_operations;
 	inode->i_fop = &simple_dir_operations;
 	inode->i_op = &cgroup_dir_inode_operations;
 	/* directories start off with i_nlink == 2 (for "." entry) */
Signature · 1 line
1.5.4.rc3

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw

2008/2/17 Li Zefan <[email protected]>:

Quoted 1 line
Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>
Quoted 20 lines

---

  kernel/cgroup.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 71cf961..879a056 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -926,7 +926,6 @@ static int cgroup_get_rootdir(struct super_block *sb)

        if (!inode)
                return -ENOMEM;
 -       inode->i_op = &simple_dir_inode_operations;
        inode->i_fop = &simple_dir_operations;
        inode->i_op = &cgroup_dir_inode_operations;
        /* directories start off with i_nlink == 2 (for "." entry) */

--
1.5.4.rc3

Acked-by on v1 7/7
#3 lore raw
In reply to Li Zefan

2008/2/17 Li Zefan <[email protected]>:

Quoted 1 line
Signed-off-by Li Zefan <[email protected]>
Acked-by Paul Menage <[email protected]>
Quoted 20 lines

---

  kernel/cgroup.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 71cf961..879a056 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -926,7 +926,6 @@ static int cgroup_get_rootdir(struct super_block *sb)

        if (!inode)
                return -ENOMEM;
 -       inode->i_op = &simple_dir_inode_operations;
        inode->i_fop = &simple_dir_operations;
        inode->i_op = &cgroup_dir_inode_operations;
        /* directories start off with i_nlink == 2 (for "." entry) */

--
1.5.4.rc3