fix RTNL-locking in tun/tap driver
Subsystems (2)
PATCH 1/1 fix RTNL-locking in tun/tap driver
Current tun/tap driver sets also net device's hw address when asked to change character device's hw address. This is a good idea, but it misses RTLN-locking, resulting following error message in 2.6.25-rc3's inetdev_event() function:
RTNL: assertion failed at net/ipv4/devinet.c (1050)
Attached patch fixes this problem.
drivers/net/tun.c renamed from drivers/net/tun.c.foo +5 -1
@@ -663,7 +663,11 @@ static int tun_chr_ioctl(struct inode *icase SIOCSIFHWADDR : {/* try to set the actual net device's hw address */ -int ret =dev_set_mac_address (tun->dev, &ifr.ifr_hwaddr); +int ret; + +rtnl_lock (); + ret =dev_set_mac_address (tun->dev, &ifr.ifr_hwaddr); +rtnl_unlock ();if (ret ==0 ) {/** Set the character device's hardware address. This is used when
From: "Kim B. Heino" <[email protected]>
Date: Wed, 27 Feb 2008 11:38:21 +0200
Quoted 10 lines
Current tun/tap driver sets also net device's hw address when asked to change character device's hw address. This is a good idea, but it misses RTLN-locking, resulting following error message in 2.6.25-rc3's
inetdev_event()function:RTNL: assertion failed at
net/ipv4/devinet.c(1050)Attached patch fixes this problem.
Signed-off-by Kim B. Heino <[email protected]>
Applied, thanks.