x86: X86_HT always enable on X86_64 SMP
PATCH 1/1 x86: X86_HT always enable on X86_64 SMP
From: Hiroshi Shimamoto <[email protected]>
X86_HT is used for hyperthreading or multicore on 32-bit.
The X86_HT on 64-bit is different from 32-bit, it means hyperthreading only. And X86_HT is not used on 64-bit except from cpu/initel_cacheinfo.c.
Unify X86_HT for hyperthreading or multicore.
Turn X86_HT on when X86_64 and SMP are enabled.
--- arch/x86/Kconfig | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/Kconfig +3 -3
@@ -174,7 +174,7 @@ config X86_64_SMP config X86_HT bool depends on SMP - depends on (X86_32 && !(X86_VISWS || X86_VOYAGER)) || (X86_64 && !MK8) + depends on (X86_32 && !(X86_VISWS || X86_VOYAGER)) || X86_64 default y config X86_BIOS_REBOOT
@@ -516,7 +516,7 @@ config NR_CPUS config SCHED_SMT bool "SMT (Hyperthreading) scheduler support" - depends on (X86_64 && SMP) || (X86_32 && X86_HT) + depends on X86_HT help SMT scheduler support improves the CPU scheduler's decision making when dealing with Intel Pentium 4 chips with HyperThreading at a
@@ -526,7 +526,7 @@ config SCHED_SMT config SCHED_MC def_bool y prompt "Multi-core scheduler support" - depends on (X86_64 && SMP) || (X86_32 && X86_HT) + depends on X86_HT help Multi-core scheduler support improves the CPU scheduler's decision making when dealing with multi-core CPU chips at a cost of slightly
Signature · 1 line
1.5.3.8
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.
Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicore
Quoted 28 lines
Signed-off-by Hiroshi Shimamoto <[email protected]>--- arch/x86/Kconfig | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)arch/x86/Kconfig +2
-2@@ -174,7 +174,7 @@ config X86_64_SMP config X86_HT bool depends on SMP - depends on (X86_32 && !(X86_VISWS || X86_VOYAGER)) || (X86_64 && !MK8) + depends on (X86_32 && !(X86_VISWS || X86_VOYAGER)) || X86_64 default y config X86_BIOS_REBOOT@@ -516,7 +516,7 @@ config NR_CPUS config SCHED_SMT bool "SMT (Hyperthreading) scheduler support" - depends on (X86_64 && SMP) || (X86_32 && X86_HT) + depends on X86_HT help SMT scheduler support improves the CPU scheduler's decision making when dealing with Intel Pentium 4 chips with HyperThreading at a
arch/x86/Kconfig config SCHED_SMT · line 532
Quoted 8 lines
arch/x86/Kconfig +1
-1@@ -526,7 +526,7 @@ config SCHED_SMT config SCHED_MC def_bool y prompt "Multi-core scheduler support" - depends on (X86_64 && SMP) || (X86_32 && X86_HT) + depends on X86_HT help Multi-core scheduler support improves the CPU scheduler's decision making when dealing with multi-core CPU chips at a cost of slightly
And any proper fix should result in SCHED_SMT and SCHED_MC getting different dependencies.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedH. Peter Anvin
reviewerQuoted 10 lines · Adrian Bunk
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.
Quoted 7 lines
Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicore
He does, and calls them SCHED_SMT and SCHED_MC respectively.
It's not particularly clear to me what X86_HT is meant to be used for anymore at all.
-hpa
Quoted 11 lines · H. Peter Anvin
Quoted 10 lines · Adrian Bunk
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.
Quoted 8 lines
Quoted 6 lines
Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicoreHe does, and calls them
SCHED_SMTandSCHED_MCrespectively.
These are the already existing scheduler related variables that are only a part of the X86_HT usages.
Quoted 2 lines
It's not particularly clear to me what
X86_HTis meant to be used for anymore at all.
grep through the source code and you find it is sometimes used for hyperthreading and sometimes for multicore.
I don't care whether X86_HT gets splitted or perhaps even removed, but any change to it should remove the status quo of it having two different semantics.
Quoted 1 line
-hpa
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 19 lines · H. Peter Anvin
Quoted 10 lines · Adrian Bunk
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.Quoted 7 lines
Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicore
Quoted 4 lines
He does, and calls them
SCHED_SMTandSCHED_MCrespectively.It's not particularly clear to me what
X86_HTis meant to be used for anymore at all.
he made X86_HT can be enabled when only Opteron supported is enabled.
it should be stated in the comments.
YH
Quoted 25 lines · Adrian Bunk
Quoted 10 lines · H. Peter Anvin
Quoted 9 lines · Adrian Bunk
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.Quoted 7 lines
Quoted 6 lines
Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicoreHe does, and calls them
SCHED_SMTandSCHED_MCrespectively.These are the already existing scheduler related variables that are only a part of the
X86_HTusages.Quoted 2 lines
It's not particularly clear to me what
X86_HTis meant to be used for anymore at all.
Quoted 6 lines
grep through the source code and you find it is sometimes used for hyperthreading and sometimes for multicore.
I don't care whether
X86_HTgets splitted or perhaps even removed, but any change to it should remove the status quo of it having two different semantics.
OK, you say "Don't mix two different semantics into one variable X86_HT", right?
Thanks,
Hiroshi Shimamoto
Quoted 20 lines · Yinghai Lu
Quoted 19 lines · H. Peter Anvin
Quoted 17 lines · Adrian Bunk
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicore
Quoted 6 lines
Quoted 4 lines
He does, and calls them
SCHED_SMTandSCHED_MCrespectively.It's not particularly clear to me what
X86_HTis meant to be used for anymore at all.he made
X86_HTcan be enabled when only Opteron supported is enabled.
yes on 64-bit. On 32-bit MK8 doesn't affect X86_HT.
Quoted 26 lines · Hiroshi Shimamoto
Quoted 25 lines · Adrian Bunk
Quoted 10 lines · H. Peter Anvin
Quoted 9 lines · Adrian Bunk
Quoted 8 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
X86_HTis used for hyperthreading or multicore on 32-bit.
TheX86_HTon 64-bit is different from 32-bit, it means hyperthreading only. AndX86_HTis not used on 64-bit except fromcpu/initel_cacheinfo.c.Unify
X86_HTfor hyperthreading or multicore.
TurnX86_HTon whenX86_64and SMP are enabled.Quoted 7 lines
Quoted 6 lines
Please fix it properly instead - fiddling around with it the way you do only asks for trouble in the future.
What we need are two different variables for:
- hyperthreading and
- multicoreHe does, and calls them
SCHED_SMTandSCHED_MCrespectively.These are the already existing scheduler related variables that are only a part of the
X86_HTusages.Quoted 2 lines
It's not particularly clear to me what
X86_HTis meant to be used for anymore at all.
Quoted 8 lines
Quoted 6 lines
grep through the source code and you find it is sometimes used for hyperthreading and sometimes for multicore.
I don't care whether
X86_HTgets splitted or perhaps even removed, but any change to it should remove the status quo of it having two different semantics.OK, you say "Don't mix two different semantics into one variable
X86_HT", right?
Exactly.
This mixing is not your fault since it's an older problem, but instead of your suggested patch we should fix it properly.
Quoted 2 lines
Thanks,
Hiroshi Shimamoto
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed