Skip to contentSkip to conversation

Stop the clock!

DISCUSSION Avi Kivity 3 participants 3 messages Mar 4, 2008 KVM

lore
Share & tools
lore

Avi Kivity

author
#0 lore raw

With paravirt clocksource, reboot and kexec are broken: the clock keeps updating after the reboot, and the new kernel will have a random memory location trampled occasionally.

So we need to stop the clock on kexec (in the guest) and reboot (in the host). On the host side, this can be done either in the kernel, or in userspace via new ioctls.

Joerg, I think you mentioned you were working on a vm-wide reset ioctl()? If so, that would be the place to stop the clock on reboot.

Glauber, can you extend the interface to support stopping the clock? It needs to be done even outside kexec, for example if the the user decides to stop using your clock.

Signature · 7 lines
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
#1 lore raw
Quoted 8 lines · Avi Kivity

With paravirt clocksource, reboot and kexec are broken: the clock keeps updating after the reboot, and the new kernel will have a random memory location trampled occasionally.

So we need to stop the clock on kexec (in the guest) and reboot (in the host). On the host side, this can be done either in the kernel, or in userspace via new ioctls.

Quoted 7 lines

Joerg, I think you mentioned you were working on a vm-wide reset ioctl()? If so, that would be the place to stop the clock on reboot.

Glauber, can you extend the interface to support stopping the clock? It needs to be done even outside kexec, for example if the the user decides to stop using your clock.

Sure, I'll work on it.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

#2 lore raw
In reply to Avi Kivity
Quoted 7 lines · Avi Kivity

With paravirt clocksource, reboot and kexec are broken: the clock keeps updating after the reboot, and the new kernel will have a random memory location trampled occasionally.

So we need to stop the clock on kexec (in the guest) and reboot (in the host). On the host side, this can be done either in the kernel, or in userspace via new ioctls.

Joerg, I think you mentioned you were working on a vm-wide reset ioctl()? If so, that would be the place to stop the clock on reboot.

Glauber, can you extend the interface to support stopping the clock? It needs to be done even outside kexec, for example if the the user decides to stop using your clock.

Yes, I am working on that ioctl(), but don't expect a patch this week because I am busy with an other task temporarily.

Joerg

Signature · 12 lines
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/