Skip to contentSkip to conversation

xtables: remove white spaces from iptables-xml manpages

PATCH Applied Filippo Zangheri 4 participants 12 messages Mar 6, 2008 – Apr 2, 2008 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xtables: remove white spaces from iptables-xml manpages

Hi,

This patch removes useless white spaces from iptables-xml manpages.

---
 iptables-xml.8 |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
iptables-xml.8 +9 -9
index 2e4a3da..705dc5e 100644
@@ -50,21 +50,21 @@ target like SNAT and another chain.
 Some sample output is:
 
 <iptables-rules>
-  <table name="mangle" >
+  <table name="mangle">
     <chain name="PREROUTING" policy="ACCEPT" packet-count="63436"
-byte-count="7137573" >
-      <rule >
+byte-count="7137573">
+      <rule>
        <conditions>
-        <match >
-          <p >tcp</p>
+        <match>
+          <p>tcp</p>
         </match>
-        <tcp >
-          <sport >8443</sport>
+        <tcp>
+          <sport>8443</sport>
         </tcp>
        </conditions>
        <actions>
-        <call >
-          <check_ip />
+        <call>
+          <check_ip/>
         </call>
         <ACCEPT/>
        </actions>
Signature · 12 lines
Filippo Zangheri

GPG key ID: 0xE1D879FA
Key fingerprint: 816B CE57 D43C 0A47 EF35 3378 EA5F A72A E1D8 79FA
Key server: pgp.mit.edu

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GE d- s+:- a-- C++ UL+++ P+ L+++ E-- W+ N* o-- K- w--- O-- M--
V- PS++ PE+ Y+ PGP++ t 5-- X++ R* tv b+ DI-- D---- G-- e++ h--
r++ z*
------END GEEK CODE BLOCK------
#1 lore raw
Quoted 3 lines · Filippo Zangheri

This patch removes useless white spaces from iptables-xml manpages.

thanks, applied.

#2 lore raw
Quoted 5 lines · Jan Engelhardt
Quoted 2 lines · Filippo Zangheri

This patch removes useless white spaces from iptables-xml manpages.

thanks, applied.

I don't understand what you do. This patch applies clean to iptables SVN. Are you supposed to be enqueuing patches that later you're going to post again to the ML? Even you're getting me confused with this...

I'm going to apply this straigh forward patch to official SVN now.

Signature · 1 line
"Los honestos son inadaptados sociales" -- Les Luthiers
#3 lore raw
Quoted 9 lines · Pablo Neira Ayuso
Quoted 4 lines · Jan Engelhardt
Quoted 1 line · Filippo Zangheri

This patch removes useless white spaces from iptables-xml manpages.

thanks, applied.

I don't understand what you do. This patch applies clean to iptables SVN. Are you supposed to be enqueuing patches that later you're going to post again to the ML? Even you're getting me confused with this...

I and others had anticipated netfilter's move to git, and I think that is a good idea. While that is in progress or so, I am already working with the sanitized svn history in git[1] on my branch(es), collecting patches against it.

[1] http://marc.info/?l=netfilter-devel&m=120450289808046&w=2

#4 lore raw
In reply to Pablo Neira Ayuso
Quoted 9 lines · Pablo Neira Ayuso
Quoted 4 lines · Jan Engelhardt
Quoted 2 lines · Filippo Zangheri

This patch removes useless white spaces from iptables-xml manpages.

thanks, applied.

I don't understand what you do. This patch applies clean to iptables SVN. Are you supposed to be enqueuing patches that later you're going to post again to the ML? Even you're getting me confused with this...

I agree, please stop this. If patches get missed, the submitter won't notice if you've already sent an "applied" message. It also increases load for us if you submit the same patch again.

#5 lore raw

Patrick McHardy ha scritto:

Quoted 6 lines
Quoted 5 lines · Pablo Neira Ayuso
Quoted 4 lines · Jan Engelhardt
Quoted 2 lines · Filippo Zangheri

This patch removes useless white spaces from iptables-xml manpages.

thanks, applied.

Quoted 8 lines
Quoted 3 lines

I don't understand what you do. This patch applies clean to iptables SVN. Are you supposed to be enqueuing patches that later you're going to post again to the ML? Even you're getting me confused with this...

I agree, please stop this. If patches get missed, the submitter won't notice if you've already sent an "applied" message. It also increases load for us if you submit the same patch again.

Hi Patrick,

First of all, I'd like to thank you and everyone who has ever participated in the development of Netfilter & co. Without you all I would have never graduate :-).

Just out of curiosity, may I ask you what's your opinion on using Git as a version control system for Netfilter stuff? And what's your opinion on switching to it?

Thank you very much.

Signature · 12 lines
Filippo Zangheri

GPG key ID: 0xE1D879FA
Key fingerprint: 816B CE57 D43C 0A47 EF35 3378 EA5F A72A E1D8 79FA
Key server: pgp.mit.edu

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GE d- s+:- a-- C++ UL+++ P+ L+++ E-- W+ N* o-- K- w--- O-- M--
V- PS++ PE+ Y+ PGP++ t 5-- X++ R* tv b+ DI-- D---- G-- e++ h--
r++ z*
------END GEEK CODE BLOCK------
#6 lore raw
Quoted 5 lines · Filippo Zangheri

Hi Patrick,

First of all, I'd like to thank you and everyone who has ever participated in the development of Netfilter & co. Without you all I would have never graduate :-).

Thanks :)

Quoted 3 lines

Just out of curiosity, may I ask you what's your opinion on using Git as a version control system for Netfilter stuff? And what's your opinion on switching to it?

I would prefer that over SVN very much, however before we switch we need to set up git on the netfilter servers, install gitweb etc. I currently don't have time to take care of this.

#7 lore raw
Quoted 8 lines · Patrick McHardy
Quoted 4 lines

Just out of curiosity, may I ask you what's your opinion on using Git as a version control system for Netfilter stuff? And what's your opinion on switching to it?

I would prefer that over SVN very much, however before we switch we need to set up git on the netfilter servers, install gitweb etc. I currently don't have time to take care of this.

You previously raised the idea of putting the repository on git.kernel.org; not that I really care where it is at, but if you need help setting it plus gitweb up, that is actually fairly easy.

All I needed for this host was enabling git-daemon in xinetd and making Apache run gitweb.cgi. 'Was kinda puzzled how long it took me to get mod_dav/authnz_svn working in comparison.

Call me if you need help ;)

#11 lore raw
In reply to Patrick McHardy

Patrick McHardy ha scritto:

Quoted 3 lines

I would prefer that over SVN very much, however before we switch we need to set up git on the netfilter servers, install gitweb etc. I currently don't have time to take care of this.

Oh, that's great to hear that the only thing that's currently keeping Netfilter development from performing that giant leap to Git is lack of time. :-)

Then I'm looking forward for the Git-switch.

Thank you.
Keep it coming.

Signature · 12 lines
Filippo Zangheri

GPG key ID: 0xE1D879FA
Key fingerprint: 816B CE57 D43C 0A47 EF35 3378 EA5F A72A E1D8 79FA
Key server: pgp.mit.edu

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GE d- s+:- a-- C++ UL+++ P+ L+++ E-- W+ N* o-- K- w--- O-- M--
V- PS++ PE+ Y+ PGP++ t 5-- X++ R* tv b+ DI-- D---- G-- e++ h--
r++ z*
------END GEEK CODE BLOCK------
#8 lore raw
In reply to Jan Engelhardt
Quoted 11 lines · Jan Engelhardt
Quoted 6 lines · Patrick McHardy
Quoted 3 lines

Just out of curiosity, may I ask you what's your opinion on using Git as a version control system for Netfilter stuff? And what's your opinion on switching to it?

I would prefer that over SVN very much, however before we switch we need to set up git on the netfilter servers, install gitweb etc. I currently don't have time to take care of this.

You previously raised the idea of putting the repository on git.kernel.org; not that I really care where it is at, but if you need help setting it plus gitweb up, that is actually fairly easy.

Moving to kernel.org would require to get an account there for all netfilter developers. Its probably easier to keep it on netfilter.org.

I know that gitweb is pretty easy to set up, I'm a bit afraid to touch the netfilter servers though (at least while Harald is on vacation) since they contain a pretty f*cked up genfoo installation with debian running in a chroot.

Quoted 6 lines

All I needed for this host was enabling git-daemon in xinetd and making Apache run gitweb.cgi. 'Was kinda puzzled how long it took me to get mod_dav/authnz_svn working in comparison.

Call me if you need help ;)

I'll get back to you if I do :)

#9 lore raw
Quoted 9 lines
Quoted 9 lines · Patrick McHardy
Quoted 6 lines
Quoted 3 lines

Just out of curiosity, may I ask you what's your opinion on using Git as a version control system for Netfilter stuff? And what's your opinion on switching to it?

I would prefer that over SVN very much, however before we switch we need to set up git on the netfilter servers, install gitweb etc. I currently don't have time to take care of this.

Quoted 8 lines
Quoted 3 lines

You previously raised the idea of putting the repository on git.kernel.org; not that I really care where it is at, but if you need help setting it plus gitweb up, that is actually fairly easy.

[...]
I know that gitweb is pretty easy to set up, I'm a bit afraid to touch the netfilter servers though (at least while Harald is on vacation) since they contain a pretty f*cked up genfoo installation with debian running in a chroot.

Is winter season still on? :)

#10 lore raw
Quoted 13 lines · Jan Engelhardt
Quoted 13 lines
Quoted 13 lines · Patrick McHardy
Quoted 2 lines
Quoted 2 lines

Just out of curiosity, may I ask you what's your opinion on using Git as a version control system for Netfilter stuff? And what's

your

Quoted 4 lines
Quoted 1 line

opinion on switching to it?

I would prefer that over SVN very much, however before we switch we need to set up git on the netfilter servers, install gitweb etc. I currently don't have time to take care of this.

You previously raised the idea of putting the repository on git.kernel.org; not that I really care where it is at, but if you need help setting it plus gitweb up, that is actually fairly easy.

Quoted 7 lines
Quoted 5 lines

[...]
I know that gitweb is pretty easy to set up, I'm a bit afraid to touch the netfilter servers though (at least while Harald is on vacation) since they contain a pretty f*cked up genfoo installation with debian running in a chroot.

Is winter season still on? :)

I'll give it a try :)