Skip to contentSkip to conversation

make apitest more useful

PATCH In review Stefan Seyfried 2 participants 3 messages Mar 6, 2008 – Mar 7, 2008

Subsystems (2)
Bluetooth drivers Kbuild
lore
Share & tools
lore

Stefan Seyfried

author
#0 lore raw

PATCH 1/1 make apitest more useful

This trivial 2-character patch makes apitest much more useful by allowing stuff like "apitest -l DiscoverDevices" to work like i'd expect it to:

home/seife/bin/apitest.seife renamed from usr/bin/apitest +1 -1
@@ -415,7 +415,7 @@ class Tester:
             self.dbus_dev_sig_setup()
             print 'Listening for events...'
 
-        elif self.cmd in mgr_cmds:
+        if self.cmd in mgr_cmds:
             try:
                 self.dbus_mgr_setup()
             except dbus.DBusException, e:

Now we can alias "hcitool scan" to "apitest -l DiscoverDevices" ;-) -- =

Stefan Seyfried
R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, N=FCrnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

maintainer
#1 lore raw

Hi Stefan,

Quoted 16 lines

This trivial 2-character patch makes apitest much more useful by allowing stuff like "apitest -l DiscoverDevices" to work like i'd expect it to:

home/seife/bin/apitest.seife renamed from usr/bin/apitest +1 -1
@@ -415,7 +415,7 @@ class Tester:
             self.dbus_dev_sig_setup()
             print 'Listening for events...'
 
-        elif self.cmd in mgr_cmds:
+        if self.cmd in mgr_cmds:
             try:
                 self.dbus_mgr_setup()
             except dbus.DBusException, e:
Quoted 1 line

Now we can alias "hcitool scan" to "apitest -l DiscoverDevices" ;-)

the apitest is really only a test program, but I applied the patch neverless.

Regards

Marcel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel

author
#2 lore raw

Hi Marcel,

Quoted 1 line · Marcel Holtmann

the apitest is really only a test program,

I know :-)
It is still useful to hand out to people for debugging their setup. As it is much more low level than bluez-gnome and kdebluetooth, it is easier to tell a bug reporter *exactly* what to do with apitest than with the grapical tools. That's why i bothered fixing that issue.

Quoted 1 line

but I applied the patch neverless.

Thanks. It now actually allows to test "DiscoverDevices" which is much more useful, even as testing tool only ;-)
-- =

Stefan Seyfried
R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, N=FCrnberg | "Well, surrounding them's out." =

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Bluez-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/bluez-devel