Skip to contentSkip to conversation

Removing kernel_thread() from stop_machine.c

PATCH Peter Teoh 1 participant 1 message Mar 7, 2008

lore
Share & tools
lore

Peter Teoh

author
#0 lore raw

I replaced the kernel_thread() API in stop_machine.c as per document: Documentation/feature-removal-schedule.txt.

Please comment.

stop_machine.c renamed from stop_machine.c.orig +4 -1
@@ -9,6 +9,7 @@
 #include <linux/stop_machine.h>
 #include <linux/syscalls.h>
 #include <linux/interrupt.h>
+#include <linux/kthread.h>
 
 #include <asm/atomic.h>
 #include <asm/semaphore.h>
@@ -92,6 +93,7 @@ static void stopmachine_set_state(enum s
 static int stop_machine(void)
 {
 	int i, ret = 0;
+	struct task_struct *task;
 
 	atomic_set(&stopmachine_thread_ack, 0);
 	stopmachine_num_threads = 0;
@@ -100,7 +102,8 @@ static int stop_machine(void)
 	for_each_online_cpu(i) {
 		if (i == raw_smp_processor_id())
 			continue;
-		ret = kernel_thread(stopmachine, (void *)(long)i,CLONE_KERNEL);
+		task = kthread_create(stopmachine, (void *)(long)i,"stopmachine");
+		ret = PTR_ERR(task);
 		if (ret < 0)
 			break;
 		stopmachine_num_threads++;